Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to #34728 - Split query with AsNoTrackingWithIdentityResolution() throws ArgumentOutOfRangeException #34742

Merged
merged 1 commit into from
Sep 24, 2024

Commits on Sep 23, 2024

  1. Fix to #34728 - Split query with AsNoTrackingWithIdentityResolution()…

    … throws ArgumentOutOfRangeException
    
    This is a regression introduced in 9.0 when trying to address a different regression (#33073)
    
    Error is caused by a bug in JsonCorrectOrderOfEntitiesForChangeTrackerValidator, specifically it uses the initial SelectExpression to analyze structure of various shaper expressions in the query. Problem is that RelationalSplitCollectionShaperExpression has its own SelectExpression that described the collection - we should use that select expression rather than the parent.
    Fix is to update SelectExpression used to process the expression when are processing RelationalSplitCollectionShaperExpression
    
    Fixes #34728
    maumar committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    effc2c6 View commit details
    Browse the repository at this point in the history