-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep parameter values out IMemoryCache in RelationalCommandCache #34803
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yinzara, this looks like a good fix - see minor comments below.
test/EFCore.Relational.Tests/Query/Internal/RelationalCommandCacheTest.cs
Outdated
Show resolved
Hide resolved
bc4f507
to
201dfe2
Compare
All done now. Sorry about all the force pushes :) |
Store only nullness and array lengths in struct form to prevent parameters memory leaks Fixes dotnet#34028
All requested modifications have been complete. All checks have passed. Ready for merge when you are. I know that this defect has technically existed for many prior versions of .NET. Do we still port defects to the Can I help in doing that or is this something only you guys do? |
Only store necessary info for parameter values RelationalCommandCacheKey to prevent memory leaks.
This a relatively serious memory leak defect and needs to be ported back to the
release/8.0
branch as well.Fixes #34028