Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmos skip sync rebase on current main #35670

Closed
wants to merge 1 commit into from
Closed

cosmos skip sync rebase on current main #35670

wants to merge 1 commit into from

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Feb 23, 2025

No description provided.

@roji
Copy link
Member

roji commented Feb 23, 2025

@maumar if this is an attempt to work on #33756, IIRC that got stuck because of some xunit limitation around how the attribute/skipping worked; we can discuss in design (this is a test cleanup issue, not sure it's very high priority).

@maumar
Copy link
Contributor Author

maumar commented Feb 24, 2025

@roji I just hit that limitation as well and tried to figure out what's going on (fine when running in test explorer in vs, but not from CI or command line - skip attribute is seemingly not picked up there).
My motivation was that conflict resolution was quite painful and will get even more painful with the navigation test refactoring, so I was hoping to get it out of the way. Looks like it's not going to be that easy, so I'm inclined to abandon it for now, and deal with bad merge in the future.

@maumar maumar closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants