-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use InvariantCulture for ChangeType() and decimal.TryParse() #35675
base: main
Are you sure you want to change the base?
Conversation
test/EFCore.SqlServer.FunctionalTests/Scaffolding/SqlServerDatabaseModelFactoryTest.cs
Show resolved
Hide resolved
@ErikEJ seems like we have the same bug in the SQLite provider, can you please make the same change there? |
Add "international" tests
@roji PR updated |
@ErikEJ FYI there are build failures. |
@roji Getting some interesting SQLite errors now, how can I debug the tests in Visual Studio? (I do not have "VS 17.16") |
I think new/preview VS is probably needed (because of the preview dotnet SDK that's required). If for some reason you can't/don't want to install that, you can work on the 9.0 branch for now (for debugging) and once everything works there, update the PR against 10... |
I am using preview, but did not have .NET 10 (is is brand new) - I will repro in the 9.0 branch, and port to main. |
@roji Found another bug - could be "interesting" to run the entire test suite with "da-DK" 😆 |
@roji Finally green 🎉 😆 |
fixes #35654