Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenTelemtryChatClient/EmbeddingGenerator for 1.30 #5815

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Update OpenTelemtryChatClient/EmbeddingGenerator for 1.30 #5815

merged 1 commit into from
Jan 27, 2025

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Jan 25, 2025 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from a team as a code owner January 25, 2025 23:05
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 77.82 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.OpenAI 77 78
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=929588&view=codecoverage-tab

eiriktsarpalis
eiriktsarpalis approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. For my education, is the changelog from 1.29 to 1.30 recorded somewhere? (couldn't immediately locate it).

@stephentoub
Copy link
Member Author

Thanks. For my education, is the changelog from 1.29 to 1.30 recorded somewhere? (couldn't immediately locate it).

https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.30.0

@stephentoub stephentoub merged commit 934f767 into dotnet:main Jan 27, 2025
6 checks passed
@stephentoub stephentoub deleted the otel130 branch January 27, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@stephentoub stephentoub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephentoub @dotnet-comment-bot @eiriktsarpalis