Fix Shapes BackgroundColor invalidation #27398
Open
+91
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
jsuarezruiz
commented
Feb 3, 2025
| @@ -5,6 +5,7 @@ namespace Microsoft.Maui.Controls.Handlers | |||
| { | |||
| public partial class RectangleHandler | |||
| { | |||
| internal static void MapBackground(IShapeViewHandler handler, Rectangle rectangle) { } | |||
There was a problem hiding this comment.
In the case of the Rectangle, BackgroundColor, Background and Fill changes should perform the same task, and fill the background color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix invalidating Shapes BackgroundColor.
We can set the background of Shapes with BackgroundColor, Background and Fill. In the case of the Rectangle, everything is applied to the background of the Shape equally. Fill > Background > BackgroundColor, Fill overwrites Background and if Background is used it overwrites BackgroundColor.
With an Ellipse, setting Background or BackgroundColor applies to the Shape's background; but if BackgroundColor or Background is applied in combination with Fill, Fill will fill the Shape and BackgroundColor is applied to the background color of the View.
Issues Fixed
Fixes #18131