Fixed Toolbar IconImageSource not updating with Binding Changes #27402
+117
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnumenon2684
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Jan 29, 2025
| { | ||
| App.WaitForElement(ToggleGlyphButton); | ||
| App.Tap(ToggleGlyphButton); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshots. Are available in the latest build. Could you commit the images?
There was a problem hiding this comment.
@jsuarezruiz , The Mac platform snapshot is not proper. I have attached the snapshots for remaining platforms. please let me know if you have any concerns.
Mac
There was a problem hiding this comment.
Will be fixed by #27492
Let's wait until merge it, then we can rebase and trigger a new build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
The toolbar item's FontImageSource Glyph is not reflecting changes when the bound property is updated in the ViewModel. The icon remains static despite property changes in the binding source.
Root Cause
The MenuItem class lacks an implementation to listen for source changes in the IconImageSource property. When the Glyph property changes in the bound FontImageSource, the MenuItem is not notified of this change.As a result, the visual update is not triggered in the UI
Description of Change
Implementing a source changed event listener for IconImageSource in the ImageSource call back. When the ImageSource changes are detected, manually triggering PropertyChanged for IconImageSource.This propagates the change through the UI update mechanism, ensuring the toolbar icon reflects the new state.
Validated the behaviour in the following platforms
Issues Fixed
Fixes #8295
Output
Before.mov
After.mov