-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Enabling ContextMenu UITests from Xamarin.UITests to Appium - 2 #27405
Open
nivetha-nagalingam
wants to merge
6
commits into
dotnet:main
Choose a base branch
from
anandhan-rajagopal:enabled-contextmenu-related-UITests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Testing] Enabling ContextMenu UITests from Xamarin.UITests to Appium - 2 #27405
nivetha-nagalingam
wants to merge
6
commits into
dotnet:main
from
anandhan-rajagopal:enabled-contextmenu-related-UITests
+424
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @nivetha-nagalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
nivetha-nagalingam
requested review from
PureWeen,
jsuarezruiz and
tj-devel709
January 28, 2025 16:21
nivetha-nagalingam
added
area-testing
Unit tests, device tests
partner/syncfusion
Issues / PR's with Syncfusion collaboration
labels
Jan 28, 2025
nivetha-nagalingam
changed the title
[Testing] Enabling ContextMenu UITests from Xamarin.UITests to Appium
[Testing] Enabling ContextMenu UITests from Xamarin.UITests to Appium - 2
Jan 28, 2025
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Jan 31, 2025
// } | ||
[Test] | ||
[Category(UITestCategories.ActivityIndicator)] | ||
public void ContextActionsIconImageSource() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing on Android:
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2361
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2376
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, IQuery query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 699
at UITest.Appium.HelperExtensions.TapBackArrow(IApp app, IQuery query) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 1983
at UITest.Appium.HelperExtensions.TapBackArrow(IApp app, String customBackButtonIdentifier) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 1973
at UITest.Appium.HelperExtensions.DismissContextMenu(IApp app) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2333
at Microsoft.Maui.TestCases.Tests.Issues.Issue1658.ContextActionsIconImageSource() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue1658.cs:line 24
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-testing
Unit tests, device tests
community ✨
Community Contribution
partner/syncfusion
Issues / PR's with Syncfusion collaboration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR focuses on re-enabling and updating following tests from the Xamarin.UITest framework to be compatible with Appium. The tests, previously commented out, are reviewed, and modified to ensure they are functional with the Appium framework.
Additionally introduced the ActivateContextMenu and DismissContextMenu methods in the HelperExtensions.cs file, aimed at improving the cross-platform testing approach by centralizing platform-specific logic into helper methods. The following changes have been made:
ActivateContextMenu:
A unified method to trigger platform-specific context actions on an element, simplifying context menu interactions across different platforms.
DismissContextMenu:
A single method to dismiss the context menu, eliminating the need for platform-specific code in test cases.
TestCases