Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Fix for flaky UITests in CI that occasionally fail. #27453

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Testing] Fix for flaky UITests in CI that occasionally fail. #27453

wants to merge 7 commits into from
+36 −24

Conversation

nivetha-nagalingam
Copy link
Contributor

@nivetha-nagalingam nivetha-nagalingam commented Jan 29, 2025 •
edited
Loading

Description of Change

This PR includes fixes for flaky UITest cases that were causing sporadic failures in the CI pipeline.

TestCases

  • Issue8761
  • Issue2354
  • Issue25514
  • Issue7393
  • Issue20535

Fixes #23064
Fixes #27272

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 29, 2025
@nivetha-nagalingam nivetha-nagalingam added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jan 29, 2025
@nivetha-nagalingam nivetha-nagalingam marked this pull request as ready for review January 29, 2025 15:59
@Copilot Copilot bot review requested due to automatic review settings January 29, 2025 15:59
@nivetha-nagalingam nivetha-nagalingam requested a review from a team as a code owner January 29, 2025 15:59
Copilot
Copilot AI reviewed Jan 29, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25514.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8761.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/UITest.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.HostApp/Issues/Issue7393.cs:6

  • [nitpick] The string 'IsGrouped is true' should be 'IsGrouped="true"' for consistency with the original format.
[Issue(IssueTracker.Github, 7393, "[Bug] CollectionView problems and crashes with IsGrouped is true",
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz requested changes Jan 30, 2025
View reviewed changes
src/Controls/tests/TestCases.Shared.Tests/UITest.cs
@@ -236,6 +236,20 @@ but both can happen.
}
}

protected void VerifyInternetConnectivity()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the Issue3262.class to avoid duplicated code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has already been updated and committed in the PR: #27284

jsuarezruiz
jsuarezruiz reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these tests are failing on Android:
image
Could be related with the VerifyInternetConnectivity method?

@nivetha-nagalingam
Copy link
Contributor Author

All these tests are failing on Android: image Could be related with the VerifyInternetConnectivity method?

@jsuarezruiz , Yes, these test failures are related to the VerifyInternetConnection method, and the fix for this issue has already been implemented in the PR #27284
For reference,
image (1)

@jsuarezruiz
Copy link
Contributor

All these tests are failing on Android: image Could be related with the VerifyInternetConnectivity method?

@jsuarezruiz , Yes, these test failures are related to the VerifyInternetConnection method, and the fix for this issue has already been implemented in the PR #27284 For reference, image (1)

So, the plan would be merge #27284 first and then rebase to fix this one, right?

@nivetha-nagalingam
Copy link
Contributor Author

nivetha-nagalingam commented Feb 5, 2025 •
edited
Loading

All these tests are failing on Android: image Could be related with the VerifyInternetConnectivity method?

@jsuarezruiz , Yes, these test failures are related to the VerifyInternetConnection method, and the fix for this issue has already been implemented in the PR #27284 For reference, image (1)

So, the plan would be merge #27284 first and then rebase to fix this one, right?

@jsuarezruiz , Yes, the plan is to first merge #27284 and then rebase here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

Copilot code review Copilot Copilot left review comments

@PureWeen PureWeen Awaiting requested review from PureWeen

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reenable disabled flaky UI tests UITests broken for net9
2 participants
@nivetha-nagalingam @jsuarezruiz