Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable xUnit verbose logging on System.IO.Tests #107149

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Aug 29, 2024

Contributes to #100558 in an attempt to visualize which test is causing OOM (error 137).

@jozkee jozkee changed the title Enable xUnit verbose logging Enable xUnit verbose logging on System.IO.Tests Aug 29, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

@carlossanlop
Copy link
Member

What will be the main difference?

There's also the Net5Compat tests failing with the same error. Are those handled with a different csproj? I don't remember. If they are, then they will need the same property added.

@jozkee
Copy link
Member Author

jozkee commented Aug 29, 2024

What will be the main difference?

This is akin to use dotnet test --logger "console;verbosity=detailed".

Net5Compat

System.IO.Net5Compat.Tests does not exist in main, it was removed in #57735.

@carlossanlop
Copy link
Member

System.IO.Net5Compat.Tests does not exist in main, it was removed in #57735

Ok good to know. So when we find the offending test, we can hopefully do something similar servicing branches to unblock the Net5Compat failing tests.

@jozkee
Copy link
Member Author

jozkee commented Aug 29, 2024

Trying #107163 before merging this.

@jozkee jozkee added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Aug 29, 2024
@jozkee
Copy link
Member Author

jozkee commented Aug 30, 2024

/ba-g error on WasmTestOnChrome-ST-System.Runtime.Tests.WorkItemExecution is #103347.

@jozkee jozkee merged commit 158a71e into dotnet:main Aug 30, 2024
82 of 85 checks passed
@jozkee jozkee deleted the io-xunit-verbose branch August 30, 2024 17:44
@jkotas
Copy link
Member

jkotas commented Aug 30, 2024

I'm still seeing OOM errors after #107163.

#107163 was merged into main. The two failures you have shared are from release/9.0. Do you still see failures in main?

@jozkee
Copy link
Member Author

jozkee commented Aug 30, 2024

Do you still see failures in main?

No, latest failure in main was https://dev.azure.com/dnceng-public/public/_build/results?buildId=793300&view=ms.vss-test-web.build-test-results-tab&runId=20409750&resultId=211437.

That happened before merging #107163. Thanks for catching that, @jkotas.

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants