[release/9.0] Fix docs file names and add validation #107359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
needs-area-label
carlossanlop
added
documentation
carlossanlop
approved these changes
Sep 4, 2024
|
Tell-mode. |
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
|
/ba-g Failure known and pre-existing #100558 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107334 to release/9.0
/cc @carlossanlop @ericstj
Customer Impact
Both customer and our validation process discovered that we were not showing intellisense in VS/VS Code anymore in RC1. This was a regression from a recent fix: The build process is giving the wrong name to the final intellisense xml files that need to be shipped to customers, so they are not getting detected and included in the final output.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
#105243
Testing
An msbuild test was added to prevent this from happening in the future: It checks that the final list of files is exactly the same as the expected list of files.
Risk
Low. It was working correctly before a recent change. We have now validated it works correctly.