[browser] Increase timeout and clean up after failed attempts of launching browser when testing

src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs

@@ -6,8 +6,10 @@
 using System;
 using System.IO;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Text.RegularExpressions;
 using System.Threading.Tasks;
+using System.Runtime.InteropServices;
 using Microsoft.Playwright;
 using Wasm.Tests.Internal;
 using Xunit.Abstractions;
@@ -19,6 +21,7 @@ internal class BrowserRunner : IAsyncDisposable
     private static Regex s_blazorUrlRegex = new Regex("Now listening on: (?<url>https?://.*$)");
     private static Regex s_appHostUrlRegex = new Regex("^App url: (?<url>https?://.*$)");
     private static Regex s_exitRegex = new Regex("WASM EXIT (?<exitCode>-?[0-9]+)$");
+    private static bool s_runsOnWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
     private static readonly Lazy<string> s_chromePath = new(() =>
     {
         string artifactsBinDir = Path.Combine(Path.GetDirectoryName(typeof(BuildTestBase).Assembly.Location)!, "..", "..", "..", "..");
@@ -103,12 +106,11 @@ public async Task<string> StartServerAndGetUrlAsync(
     public async Task<IBrowser> SpawnBrowserAsync(
         string browserUrl,
         bool headless = true,
-        int timeout = 10000,
-        int maxRetries = 3,
+        int? timeout = null,
+        int maxRetries = 3,        
         string language = "en-US"
     ) {
         var url = new Uri(browserUrl);
-        Playwright = await Microsoft.Playwright.Playwright.CreateAsync();
         // codespaces: ignore certificate error -> Microsoft.Playwright.PlaywrightException : net::ERR_CERT_AUTHORITY_INVALID
         string[] chromeArgs = new[] { $"--explicitly-allowed-ports={url.Port}", "--ignore-certificate-errors", $"--lang={language}" };
         _testOutput.WriteLine($"Launching chrome ('{s_chromePath.Value}') via playwright with args = {string.Join(',', chromeArgs)}");
@@ -118,8 +120,14 @@ public async Task<IBrowser> SpawnBrowserAsync(
         {
             try
             {
+                // widnows runs are sequential, we cannot terminate when we run in parallel
+                if (s_runsOnWindows)
+                {
+                    TerminateExistingChromeInstances();
+                }
+                Playwright = await Microsoft.Playwright.Playwright.CreateAsync();
                 Browser = await Playwright.Chromium.LaunchAsync(new BrowserTypeLaunchOptions {
-                    ExecutablePath = s_chromePath.Value,
+                    // ExecutablePath = s_chromePath.Value,
                     Headless = headless,
                     Args = chromeArgs,
                     Timeout = timeout
@@ -129,17 +137,53 @@ public async Task<IBrowser> SpawnBrowserAsync(
                     Browser = null;
                     _testOutput.WriteLine("Browser has been disconnected");
                 };
-                break;
+                return Browser!;
             }
             catch (System.TimeoutException ex)
             {
                 attempt++;
-                _testOutput.WriteLine($"Attempt {attempt} failed with TimeoutException: {ex.Message}");
+                _testOutput.WriteLine($"Attempt {attempt} failed with TimeoutException: {ex}");
+
+                try
+                {
+                    // Cleanup before retrying
+                    if (Browser != null)
+                    {
+                        await Browser.CloseAsync();
+                        Browser = null;
+                    }
+                    if (Playwright != null)
+                    {
+                        Playwright.Dispose();
+                        Playwright = null;
+                    }
+                }
+                catch(Exception cleanupException)
+                {
+                    _testOutput.WriteLine($"Attempt to clean up failed with {cleanupException}");
+                }
+            }
+        }
+        throw new Exception($"Failed to launch browser after {maxRetries} attempts");
+    }
+
+    private void TerminateExistingChromeInstances()
+    {
+        try
+        {
+            var chromeProcesses = Process.GetProcessesByName("chrome");
+            _testOutput.WriteLine($"Found {chromeProcesses.Length} old Chrome processes.");
+            foreach (var process in chromeProcesses)
+            {
+                _testOutput.WriteLine($"Terminating existing Chrome process: {process.Id}");
+                process.Kill();
+                process.WaitForExit();
             }
         }
-        if (attempt == maxRetries)
-            throw new Exception($"Failed to launch browser after {maxRetries} attempts");
-        return Browser!;
+        catch (Exception ex)
+        {
+            _testOutput.WriteLine($"Failed to terminate existing Chrome instances: {ex}");
+        }
     }
 
     // FIXME: options

src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj

@@ -87,6 +87,14 @@
       <RunScriptCommands Condition="'$(OS)' != 'Windows_NT'" Include="export IS_RUNNING_ON_CI=true" />
       <RunScriptCommands Condition="'$(OS)' == 'Windows_NT'" Include="set IS_RUNNING_ON_CI=true" />
 
+      <!-- avoids "Executable doesn't exist. Looks like Playwright was just installed or updated." -->
+      <RunScriptCommands Condition="'$(OS)' != 'Windows_NT'" Include="npx playwright install" />
+
+      <!-- prividing info for the issue in Playwright -->
+      <RunScriptCommands Include="npx envinfo --preset playwright" />
+
+      <!-- <RunScriptCommands Condition="'$(OS)' == 'Windows_NT'" Include="set DEBUG=pw:browser*" /> -->
+
       <RunScriptCommands Condition="'$(OS)' != 'Windows_NT'" Include="chmod +x $HELIX_WORKITEM_ROOT/.playwright/node/linux-x64/playwright.sh" />
       <RunScriptCommands Condition="'$(OS)' != 'Windows_NT'" Include="chmod +x $HELIX_WORKITEM_ROOT/.playwright/node/linux-x64/node" />
     </ItemGroup>