Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Do not use link flags for bitcode compilation #108846

Open
wants to merge 5 commits into
base: release/8.0
Choose a base branch
from
Open

[wasm] Do not use link flags for bitcode compilation #108846

wants to merge 5 commits into from

Commits on Oct 14, 2024

  1. [wasm] Do not use link flags for bitcode compilation 

    Backport of (dotnet#101397)

This avoids errors like:

    /root/helix/work/correlation/build/wasm-shared/WasmApp.Common.targets(832,5): error : emcc: warning: linker setting ignored during compilation: 'EXPORT_ES6' [-Wunused-command-line-argument] [/root/helix/work/workitem/e/publish/ProxyProjectForAOTOnHelix.proj]
    /root/helix/work/correlation/build/wasm-shared/WasmApp.Common.targets(832,5): error : emcc: warning: linker setting ignored during compilation: 'EXPORT_EXCEPTION_HANDLING_HELPERS' [-Wunused-command-line-argument] [/root/helix/work/workitem/e/publish/ProxyProjectForAOTOnHelix.proj]

This should helps with known build error dotnet#104827
where the warning can hide another errors
    @radekdoulik
    radekdoulik committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e898a13 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Backport of [wasm] Add optimization flags to bitcode compilation (dot… 

    …net#101538)
    @radekdoulik
    radekdoulik committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    626cf6c View commit details
    Browse the repository at this point in the history

  2. Fix build

    @radekdoulik
    radekdoulik committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    52bae1c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Keep using EmccLinkOptimizationFlag to reduce the changes

    @radekdoulik
    radekdoulik committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8844294 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge branch 'release/8.0' into pr-es6-warning

    @radekdoulik
    radekdoulik authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    17e838d View commit details
    Browse the repository at this point in the history