Always inline number conversions

[hez2010]

We applied AggressiveInlining for most TryConvert*, except several leftovers.

Apply it for them as well.

Otherwise they will not be inlined: https://godbolt.org/z/h5dz6sKa5

Searched with bool\s+.*TryConvert.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

[hez2010]

@MihuBot

[hez2010]

@EgorBot -intel

using System.Numerics;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;

// Actual runner is optional, but if it exists, it has to be like this:
BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);

public class Bench
{
    [Benchmark]
    public double GetDouble() => CastNumber<double>(42);

    static T CastNumber<T>(int v) where T : INumberBase<T>
    {
        return T.CreateTruncating(v);
    }
}

[hez2010]

Benchmark on linux_azure_genoa:

Method	Toolchain	Mean	Error	Ratio
GetDouble	Main	1.0728 ns	0.0001 ns	1.000
GetDouble	PR	0.0000 ns	0.0000 ns	0.000

Benchmark on linux_azure_cascadelake:

Method	Toolchain	Mean	Error	Ratio
GetDouble	Main	0.8452 ns	0.0005 ns	1.00
GetDouble	PR	0.0179 ns	0.0001 ns	0.02

[tannergooding]

@hez2010 you should run a benchmark that isn't constant foldable as well; so more accurate numbers can be given.

[hez2010]

@EgorBot -intel

using System.Numerics;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;

// Actual runner is optional, but if it exists, it has to be like this:
BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);

public class Bench
{
    private int v = 42;

    [Benchmark]
    public double GetDouble() => CastNumber<double>(this.v);

    static T CastNumber<T>(int v) where T : INumberBase<T>
    {
        return T.CreateTruncating(v);
    }
}

[hez2010]

Saved the int to a class field to prevent constant folding and make it always load from the address.

Method	Toolchain	Mean	Error	Ratio
GetDouble	Main	1.1684 ns	0.0002 ns	1.000
GetDouble	PR	0.0000 ns	0.0000 ns	0.000