Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, this would break when
LowerNode
ended up deciding to remove the current node.To make this fully robust we now insert a sentinel node and stop when we get to it. Using
lastNode->gtNext
as the sentinel node would seemingly be possible, but we have code that removes the user of the node being lowered, which would not work in that scenario:runtime/src/coreclr/jit/lowerxarch.cpp
Lines 1506 to 1514 in 78142b0