Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/runtime #44014

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 9, 2024

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport: from 10.0.0-alpha.1.24504.3 to 10.0.0-alpha.1.24514.2 (parent: Microsoft.NETCore.App.Runtime.win-x64)
    • Microsoft.SourceBuild.Intermediate.emsdk: from 10.0.0-alpha.1.24504.3 to 10.0.0-alpha.1.24514.2 (parent: Microsoft.NETCore.App.Runtime.win-x64)

From https://github.com/dotnet/runtime

  • Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
  • Build: 20241017.1
  • Date Produced: October 17, 2024 11:58:22 AM UTC
  • Commit: 2830cf5d4b6c7853c6f187b8646ee7cfda7a9ae7
  • Branch: refs/heads/main

…1008.15

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24507.22 -> To Version 10.0.0-alpha.1.24508.15

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 10.0.0-alpha.1.24474.1 -> To Version 10.0.0-alpha.1.24504.3 (parent: Microsoft.NETCore.App.Runtime.win-x64
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Oct 9, 2024
Copy link
Contributor Author

dotnet-maestro bot commented Oct 9, 2024

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@nagilson
Copy link
Member

nagilson commented Oct 9, 2024

Same as #44012

@lewing
Copy link
Member

lewing commented Oct 9, 2024

@maraf @jeromelaban please take a look at the blazor test failures

@maraf maraf requested a review from a team as a code owner October 10, 2024 09:28
maraf and others added 4 commits October 10, 2024 12:35
…1009.15

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24508.15 -> To Version 10.0.0-alpha.1.24509.15
@maraf
Copy link
Member

maraf commented Oct 10, 2024

The remaining failure (dotnet-sdk-public-ci (Build FullFramework: windows (x64))) is

C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\.nuget\packages\microsoft.net.sdk.webassembly.pack\10.0.0-alpha.1.24509.15\build\Microsoft.NET.Sdk.WebAssembly.Browser.targets(366,5): error : System.IO.FileNotFoundException: Could not load file or assembly 'System.Text.Json, Version=8.0.0.5, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified. [C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\Build_Service---C624F51F\blazorwasm\blazorwasm.csproj]
        C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\.nuget\packages\microsoft.net.sdk.webassembly.pack\10.0.0-alpha.1.24509.15\build\Microsoft.NET.Sdk.WebAssembly.Browser.targets(366,5): error : File name: 'System.Text.Json, Version=8.0.0.5, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' [C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\Build_Service---C624F51F\blazorwasm\blazorwasm.csproj]
        C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\.nuget\packages\microsoft.net.sdk.webassembly.pack\10.0.0-alpha.1.24509.15\build\Microsoft.NET.Sdk.WebAssembly.Browser.targets(366,5): error :    at Microsoft.NET.Sdk.WebAssembly.GenerateWasmBootJson.WriteBootJson(Stream output, String entryAssemblyName) [C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\Build_Service---C624F51F\blazorwasm\blazorwasm.csproj]
        C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\.nuget\packages\microsoft.net.sdk.webassembly.pack\10.0.0-alpha.1.24509.15\build\Microsoft.NET.Sdk.WebAssembly.Browser.targets(366,5): error :    at Microsoft.NET.Sdk.WebAssembly.GenerateWasmBootJson.Execute() [C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\Build_Service---C624F51F\blazorwasm\blazorwasm.csproj]
        C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\.nuget\packages\microsoft.net.sdk.webassembly.pack\10.0.0-alpha.1.24509.15\build\Microsoft.NET.Sdk.WebAssembly.Browser.targets(366,5): error :  [C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\Build_Service---C624F51F\blazorwasm\blazorwasm.csproj]
        C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\.nuget\packages\microsoft.net.sdk.webassembly.pack\10.0.0-alpha.1.24509.15\build\Microsoft.NET.Sdk.WebAssembly.Browser.targets(366,5): error : WRN: Assembly binding logging is turned OFF. [C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\Build_Service---C624F51F\blazorwasm\blazorwasm.csproj]
        C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\.nuget\packages\microsoft.net.sdk.webassembly.pack\10.0.0-alpha.1.24509.15\build\Microsoft.NET.Sdk.WebAssembly.Browser.targets(366,5): error : To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1. [C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\Build_Service---C624F51F\blazorwasm\blazorwasm.csproj]
        C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\.nuget\packages\microsoft.net.sdk.webassembly.pack\10.0.0-alpha.1.24509.15\build\Microsoft.NET.Sdk.WebAssembly.Browser.targets(366,5): error : Note: There is some performance penalty associated with assembly bind failure logging. [C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\Build_Service---C624F51F\blazorwasm\blazorwasm.csproj]
        C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\.nuget\packages\microsoft.net.sdk.webassembly.pack\10.0.0-alpha.1.24509.15\build\Microsoft.NET.Sdk.WebAssembly.Browser.targets(366,5): error : To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog]. [C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\Build_Service---C624F51F\blazorwasm\blazorwasm.csproj]
        C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\.nuget\packages\microsoft.net.sdk.webassembly.pack\10.0.0-alpha.1.24509.15\build\Microsoft.NET.Sdk.WebAssembly.Browser.targets(366,5): error :  [C:\h\w\B0EC0997\t\dotnetSdkTests\zbey5ghz.0ec\Build_Service---C624F51F\blazorwasm\blazorwasm.csproj]

maraf and others added 3 commits October 11, 2024 12:40
…1010.11

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24509.15 -> To Version 10.0.0-alpha.1.24510.11
dotnet-maestro bot and others added 2 commits October 12, 2024 12:51
…1011.14

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24510.11 -> To Version 10.0.0-alpha.1.24511.14
@lewing
Copy link
Member

lewing commented Oct 13, 2024

@ericstj it looks like the task isn't finding the STJ it wants?

@ericstj
Copy link
Member

ericstj commented Oct 14, 2024

@ericstj it looks like the task isn't finding the STJ it wants?

Tasks in the SDK need to keep S.T.J on either live (exact match, provided by SDK) or <= the one in VS / MSBuild (redirects will load). I previously tried to make more components in runtime use the live copy much of that failed because the test infrastructure for those components isn't set up correctly to test what is built. So long as we're referencing non-live bits we're going to be chasing CVE warnings / binding problems like this. It'd be much better to have them build against live bits.

dotnet-maestro bot and others added 2 commits October 15, 2024 12:59
…1014.25

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24511.14 -> To Version 10.0.0-alpha.1.24514.25
@maraf
Copy link
Member

maraf commented Oct 15, 2024

What version of System.Text.Json does the .NET framework MSBuild include? Are the tests using new enough VS?

@kasperk81
Copy link
Contributor

#44011 is bringing this change dotnet/msbuild@eacead3#diff-2c2e83275077d3c65c1190f9aabc894271ab22132b4f5675f16fb1301c0639d8

…1016.1

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24514.25 -> To Version 10.0.0-alpha.1.24516.1

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 10.0.0-alpha.1.24504.3 -> To Version 10.0.0-alpha.1.24514.2 (parent: Microsoft.NETCore.App.Runtime.win-x64
…1016.13

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24516.1 -> To Version 10.0.0-alpha.1.24516.13
@dsplaisted
Copy link
Member

/azp run dotnet-sdk-public-ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dsplaisted
Copy link
Member

Tasks in the SDK need to keep S.T.J on either live (exact match, provided by SDK) or <= the one in VS / MSBuild (redirects will load). I previously tried to make more components in runtime use the live copy much of that failed because the test infrastructure for those components isn't set up correctly to test what is built. So long as we're referencing non-live bits we're going to be chasing CVE warnings / binding problems like this. It'd be much better to have them build against live bits.

@ericstj If I'm understanding correctly, in the SDK build we have SystemTextJsonPackageVersion which is the live version, and SystemTextJsonToolsetPackageVersion which is the "VS or less" or "toolset" version, currently set to 8.0.4.

You're saying the only thing stopping us from using the live versions everywhere was some issues with the test infrastructure? Does perf in VS and the need for binding redirects if different modules build against different versions not also factor in to it?

/cc @rainersigwald

@dsplaisted
Copy link
Member

/azp run sdk-source-build sdk-unified-build

Copy link

No pipelines are associated with this pull request.

@dsplaisted
Copy link
Member

/azp run sdk-source-build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dsplaisted
Copy link
Member

/azp run sdk-unified-build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ericstj
Copy link
Member

ericstj commented Oct 17, 2024

You're saying the only thing stopping us from using the live versions everywhere was some issues with the test infrastructure?

This was specific to the use of Json in Microsoft.NET.HostModel. That component is built in a way that it can't easily take a dependency on the live version and test it, since its tests aren't running on the latest runtime. cc @agocke There are a couple other uses of Toolset versions of packages for things delivered to SDK from runtime.

Probably there are other blockers here on using live versions - like NuGet. Today we don't flow runtime through Nuget to get to the SDK, so it can't reference a live version. Roslyn and MSBuild are the same.

I think the solution in general is the plugin targeting pack solution - let these things target a baseline version that's guaranteed by the host (SDK or VS). The host will ensure it provides redirects for all the API exposed. The targeting pack will not carry with it any problematic dependencies / packages since it's only references.

@kasperk81
Copy link
Contributor

/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj(228,5): error : Missing 'RelativeBlobPath' property on blob /vmr/src/runtime/artifacts/packages/Release/Shipping/dotnet-apphost-pack-10.0.0-alpha.1.24516.13-centos.9-x64.tar.gz

anyone looking into this?

maraf and others added 2 commits October 18, 2024 10:02
…1017.1

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 10.0.0-alpha.1.24516.13 -> To Version 10.0.0-alpha.1.24517.1
@rainersigwald
Copy link
Member

Does perf in VS and the need for binding redirects if different modules build against different versions not also factor in to it?

Yes, you can get better perf in VS/MSBuild.exe scenarios by using the host-provided STJ, since we ngen it at VS install time and may have already loaded it.

@rainersigwald
Copy link
Member

What version of System.Text.Json does the .NET framework MSBuild include? Are the tests using new enough VS?

VS 17.12 uses 8.0.5, and may be all we need to care about here in main/.NET 10, but the 17.12 Helix images haven't rolled out yet so the VS tests are still running against 17.11 AFAIK.

@dsplaisted
Copy link
Member

/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj(228,5): error : Missing 'RelativeBlobPath' property on blob /vmr/src/runtime/artifacts/packages/Release/Shipping/dotnet-apphost-pack-10.0.0-alpha.1.24516.13-centos.9-x64.tar.gz

anyone looking into this?

@dotnet/source-build to look into this, and @dotnet/product-construction to look at the unified build failures.

@kasperk81
Copy link
Contributor

@jkoritzinsky already has a pr up dotnet/runtime#108990

@dsplaisted
Copy link
Member

What version of System.Text.Json does the .NET framework MSBuild include? Are the tests using new enough VS?

VS 17.12 uses 8.0.5, and may be all we need to care about here in main/.NET 10, but the 17.12 Helix images haven't rolled out yet so the VS tests are still running against 17.11 AFAIK.

@marcpopMSFT Do we know when we'll have VS 17.12 helix images available? Should we disable the failing tests (looks like they're all Blazor or Razor) on Full Framework for now?

@marcpopMSFT
Copy link
Member

@marcpopMSFT Do we know when we'll have VS 17.12 helix images available? Should we disable the failing tests (looks like they're all Blazor or Razor) on Full Framework for now?

We don't have an ETA for that. It might be next week but I don't think we can count on that so it's potentially longer. Disabling in the full framework leg seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow Area-VMR untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.