Add Localization #2051
Draft
Add Localization #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test adding localization to the extension using the new L10N Method devised by VS Code. Has some bad Japanese which is done via google translate. Proof of concept. Need to verify strings with args and that setting the language in vscode actually impacts the language of the tool. Some errors need to get put into the log in english and put into the user window (error handler) not in english. But they have embedded args which are part of the string that need to go into the log and are not available past the time the error is thrown, We will likely need to create our own simple localizableString class with string and the args array that the log will parse and then l10n can parse for the user facing output. We can do the same and handle event strings in the output channel observer, etc. Does not include @vscode/l10n @vscode/l10n-dev in the package jsons as that seems to be a - for vscode internal, and b - a global npm tool invoke-able via npx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test adding localization to the extension using the new L10N Method devised by VS Code.
Has some bad Japanese which is done via google translate. Proof of concept.
Need to verify strings with args and that setting the language in vscode actually impacts the language of the tool.
Some errors need to get put into the log in english and put into the user window (error handler) not in english. But they have embedded args which are part of the string that need to go into the log and are not available past the time the error is thrown, We will likely need to create our own simple localizableString class with string and the args array that the log will parse and then l10n can parse for the user facing output.
We can do the same and handle event strings in the output channel observer, etc.
Does not include @vscode/l10n @vscode/l10n-dev in the package jsons as that seems to be a - for vscode internal, and b - a global npm tool invoke-able via npx.