Remove duplicated code/branch to call into Milcore in Geometry #10386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes duplicate code to call
MilUtility_PathGeometryWiden. This was overlooked in #9365 where it has previously made sense but after the change it is no longer the case.fixedon anullarray will return anullpointer so we may as well remove the branch altogether and let JIT do its thing. There's also no difference in perf, besides the removed the branch, that's always nice.Customer Impact
Cleaner codebase for developrs.
Regression
Well, kinda, previously it made sense due to use of
GCHandle, now its just a useless branch.Testing
Local build.
Risk
Low.