chore: improve metadata handling #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
puckey
commented
Jul 4, 2023
•
puckey
commented
- fix pixelated display of artwork (see Android 13 Notification Player Images are pixelated and blurry react-native-track-player#1934)
- move MediaSource.getMediaMetadataCompat() extension to MediaItem.getAudioItemHolder()
- introduce MediaItem.getAudioItemHolder() extension
- throttle invalidate function directly
- avoid unnecessary resetting of media metadata provider
- fix unnecessary resetting of artwork bitmap in notificationMetadata setter
- remove tail call of invalidate (unless someone can show it is needed)
- remove PlayerConfig.androidNotificationThrottleInterval again
- avoid flickering of notification when changing config by skipping recreation of notification manager when it is not necessary
- fix pixelated display of artwork - move MediaSource.getMediaMetadataCompat() extension to MediaItem.getAudioItemHolder() - introduce MediaItem.getAudioItemHolder() extension - throttle invalidate function directly - avoid unnecessary resetting of media metadata provider - fix unnecessary resetting of artwork bitmap in notificationMetadata setter - remove tail call of invalidate (unless someone can show it is needed) - remove PlayerConfig.androidNotificationThrottleInterval again
|
I will be testing this pr tomorrow on various devices |
|
Added some changes:
Should be ready for review now.. |
- treat notification metadata bitmap as seperate from the one belonging to individual tracks - introduce notification metadata helpers to avoid duplication on somewhat complicated fallbacks from notification metadata to media metadata to item fields etc - inline getMediaMetadataCompat helper into NotificationManager - remove notificationMetadataFlow since it isn’t necessary - separate cache for now playing bitmap - when bitmap is loaded, call invalidate() in order to refire mediaSessionConnector.setMediaMetadataProvider and getCurrentLargeIcon callbacks - avoid lockscreen ui jumping when loading artwork by returning transparent placeholder image in getCurrentLargeIcon
(tested this briefly on 7 devices from android 7 to android 13..) |
jspizziri
approved these changes
Jul 6, 2023
| mediaSessionConnector.invalidateMediaSessionMetadata() | ||
| if (invalidateThrottleCount++ == 0) { | ||
| scope.launch { | ||
| internalNotificationManager?.invalidate() |
There was a problem hiding this comment.
still feels like we're spamming the invalidate methods, but I guess if they don't complain and it generally works its fine.
|
Thanks for doing this @puckey ! |
This was referenced Jul 13, 2023
…s-flickering-updateOptions Fix/notification controls flickering update options
|
Merged in the following pr which fixes an issue where the controls were flickering when the notification was configured multiple times on older versions of Android: #82 |
jspizziri
approved these changes
Jul 17, 2023
jspizziri
approved these changes
Jul 17, 2023
dcvz
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.