Skip to content

Commit

Permalink
Check wether M1 detection works
Browse files Browse the repository at this point in the history
Signed-off-by: Douglas Camata <[email protected]>
  • Loading branch information
douglascamata committed Feb 1, 2024
1 parent 3a495e3 commit 473519d
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 2 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ on:

jobs:
setup-docker:
runs-on: macos-latest
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [macos-13, macos-14]
name: A job to perform a self-test on this Github Action
steps:
# To use this repository's private action,
Expand Down
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,15 @@ I intend this action to be kept as simple as possible:
- No other OS will be supported.
- Binaries will be downloaded directly from the source when possible.

# M1, M2, M3 series are unsupported!

Yes, exactly what you just read. These processors do not support nested
virtualization. This means Colima can't start the VM to run Docker.

I'm sorry, but there's nothing I can do about it. All we can do is wait until
an M-series processor supports it and Github adopts such processors for action
runners.

## Features

- Safety check to ensure the action is running in macOS.
Expand Down
8 changes: 7 additions & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,18 @@ outputs:
runs:
using: "composite"
steps:
- name: Safety check
- name: OS safety check
if: runner.os != 'macOS'
run: |
echo "Not a macOS runner, exiting."
exit 1
shell: bash
- name: M-series safety check
if: matrix.os == 'macos-14'
run: |
echo "Detected M-series processor runner without nested virtualization support, exiting."
exit 1
shell: bash
- name: Update Homebrew
run: |
echo "::group::Updating Homebrew"
Expand Down

0 comments on commit 473519d

Please sign in to comment.