Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The automation module only recognizes uppercase in the hex encoding #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rwa
Copy link

@rwa rwa commented Dec 30, 2017

Page 5 of the Protocol document:

"Data
An 8-bit binary value is sent as two upper-case ASCII digits (‘0’...’9’, ‘A’...’F’)."

This is a suprisingly latent bug, since the most commonly used data sent to the module happens to use numbers and not hex letters. But even then it can affect checksums sporadically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant