Correct new card fee type error

dougpenny · Aug 20, 2024 · 30b4d44 · 30b4d44
1 parent 5b2022d
commit 30b4d44
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/profiles/views.py b/profiles/views.py
@@ -1,3 +1,4 @@
+import decimal
 import io
 import logging
 import operator
@@ -181,7 +182,7 @@ def new_individual_card(request, pk):
         if "waive-fee" in request.POST:
             cost = 0
         else:
-            cost = SiteConfiguration.get_solo().new_card_fee
+            cost = decimal.Decimal(SiteConfiguration.get_solo().new_card_fee)
         try:
             profile = Profile.objects.get(id=pk)
             transaction = Transaction(

diff --git a/transactions/helpers.py b/transactions/helpers.py
@@ -40,8 +40,8 @@ def create_deposit(deposit: dict) -> Transaction:
         )
         transaction.save()
         return transaction
-    except:
-        raise Exception
+    except Exception as e:
+        raise e
 
 
 def create_order(order: dict) -> Transaction:
@@ -80,8 +80,8 @@ def create_order(order: dict) -> Transaction:
                 # Why would we recevie a transaction ID for an order that doesn't exist?
                 pass
         return new_order
-    except:
-        raise Exception
+    except Exception as e:
+        raise e
 
 
 def process_transaction(transaction: Transaction):
@@ -98,5 +98,5 @@ def process_transaction(transaction: Transaction):
         transaction.save()
         transactee.current_balance = transaction.ending_balance
         transactee.save()
-    except:
-        raise Exception
+    except Exception as e:
+        raise e