Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] script order change (finish) #24

Merged
merged 2 commits into from
Feb 12, 2024
Merged

[Enhancement] script order change (finish) #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8891437
update: finish command now fetch-pull even if base task doesnt exist
Feb 12, 2024
50537e2
update: script order changed
Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,4 +176,7 @@ It will force developers to manage there works( not Task ) with PR.


- 💻 __<U>Invoke Sync before pr</U>__
> Sync should be invoked to prevent duplicate pushes<!-->End of Placeholder of OH-MY-TASK<-->
> Sync should be invoked to prevent duplicate pushes
- 💻 __<U>fetch and pull after checkout on finish command</U>__
<!-->End of Placeholder of OH-MY-TASK<-->
2 changes: 2 additions & 0 deletions src/task/finish.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ export async function finish() {
false
);
await git.checkout(branchToCheckout);
await git.fetch();
await git.pull();
return;
}
let baseBranch = task.baseBranch;
Expand Down
Loading