Add event number input and Fake axis check #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiurem66
changed the title
|
Thank you for your contribution. The event number can already be accepted as a command-line argument, so I'm not sure why you added another way to enter it. |
dperelman
reviewed
Oct 26, 2022
| @@ -17,7 +17,7 @@ def list_active_evdev(): | |||
| try: | |||
| devices.append(evdev.device.InputDevice(dev)) | |||
| except (IOError, OSError): | |||
| # Don't have permissions for that device, ignore it. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it might be useful to let the user input the event number if he already know.
Also some controllers use Axis to represent digital input using 1 and -1 as max value. I added a check for this edge case but i think it might be useful to change the +/-20 threshold to an incremental threshold.