Check faccessat #24
Closed
Check faccessat #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix.access uses RUID and RGID, which is not correct when doing a PATH-search. The faccessat function is able to check permissions using EUID and EGID instead. opam's hand-rolled check_permissions function is therefore replaced with a binding for faccessat. This simultaneously fixes two other things: - Platforms (such as Cygwin) which use ACLs no longer need special support, because their implementations of faccessat already take ACLs into account - We no longer use Unix.getgroups which means that we work around a problem with binaries built using musl libc and then used on systems where a user belongs to more than 32 groups (cf. https://www.openwall.com/lists/musl/2021/07/03/1)
As opam now routinely has stubs, eliminate the complicated dances for only linking stub libraries on Windows.
Return a boolean rather than raising an exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.