Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove redundant allocations for streamer #4225

Merged
merged 7 commits into from
Dec 5, 2024
Merged

refactor: remove redundant allocations for streamer #4225

merged 7 commits into from
Dec 5, 2024

Conversation

BorysTheDev
Copy link
Contributor

fixes: #4158

@BorysTheDev BorysTheDev force-pushed the reduce_number_of_allocations_for_streamer branch 5 times, most recently from c01a246 to 351de74 Compare November 29, 2024 14:28
@BorysTheDev BorysTheDev force-pushed the reduce_number_of_allocations_for_streamer branch from 351de74 to 2f3ce9f Compare November 29, 2024 14:35
@BorysTheDev BorysTheDev changed the title refactor: remove redundant allocations for streamer (Not ready for review) refactor: remove redundant allocations for streamer Nov 29, 2024
chakaz
chakaz reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@chakaz chakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!
Please see some nits, but that's a good change!

src/server/journal/streamer.h Outdated Show resolved Hide resolved
src/server/journal/streamer.cc Outdated Show resolved Hide resolved
src/server/journal/streamer.cc Outdated Show resolved Hide resolved
src/server/journal/streamer.cc Outdated Show resolved Hide resolved
@BorysTheDev BorysTheDev force-pushed the reduce_number_of_allocations_for_streamer branch from 2f3ce9f to 4b18ccd Compare December 2, 2024 15:06
@BorysTheDev BorysTheDev requested a review from chakaz December 3, 2024 13:03
chakaz
chakaz reviewed Dec 3, 2024
View reviewed changes
src/server/journal/streamer.cc Outdated Show resolved Hide resolved
src/server/journal/streamer.h Outdated Show resolved Hide resolved
src/server/journal/streamer.h Outdated Show resolved Hide resolved
src/server/journal/streamer.h Outdated Show resolved Hide resolved
src/server/journal/streamer.cc Outdated Show resolved Hide resolved
src/server/journal/streamer.h Outdated Show resolved Hide resolved
chakaz
chakaz reviewed Dec 4, 2024
View reviewed changes
src/server/journal/streamer.cc Outdated Show resolved Hide resolved
src/server/journal/streamer.h Outdated Show resolved Hide resolved
src/server/journal/streamer.h Outdated Show resolved Hide resolved
@BorysTheDev BorysTheDev requested a review from chakaz December 4, 2024 11:55
@BorysTheDev BorysTheDev force-pushed the reduce_number_of_allocations_for_streamer branch from 40b9c91 to 7658332 Compare December 4, 2024 12:05
@BorysTheDev BorysTheDev force-pushed the reduce_number_of_allocations_for_streamer branch from 7658332 to 09e351f Compare December 4, 2024 12:11
chakaz
chakaz reviewed Dec 4, 2024
View reviewed changes
src/server/journal/journal_test.cc Show resolved Hide resolved
src/server/journal/pending_buf.h Outdated Show resolved Hide resolved
src/server/journal/pending_buf.h Show resolved Hide resolved
src/server/journal/journal_test.cc Outdated Show resolved Hide resolved
src/server/journal/pending_buf.h Outdated Show resolved Hide resolved
src/server/journal/pending_buf.h Outdated Show resolved Hide resolved
src/server/journal/journal_test.cc Outdated Show resolved Hide resolved
src/server/journal/journal_test.cc Outdated Show resolved Hide resolved
@BorysTheDev BorysTheDev requested a review from chakaz December 4, 2024 14:16
chakaz
chakaz reviewed Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@chakaz chakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/server/journal/journal_test.cc Outdated Show resolved Hide resolved
src/server/journal/journal_test.cc Outdated Show resolved Hide resolved
chakaz
chakaz previously approved these changes Dec 5, 2024
View reviewed changes
@BorysTheDev BorysTheDev enabled auto-merge (squash) December 5, 2024 07:37
@BorysTheDev BorysTheDev merged commit 071e299 into main Dec 5, 2024
9 checks passed
@BorysTheDev BorysTheDev deleted the reduce_number_of_allocations_for_streamer branch December 5, 2024 08:15
BorysTheDev added a commit that referenced this pull request Dec 6, 2024
@BorysTheDev
Revert "refactor: remove redundant allocations for streamer (#4225)"
e436fea 
This reverts commit 071e299.
@BorysTheDev BorysTheDev mentioned this pull request Dec 6, 2024
Closed
BorysTheDev added a commit that referenced this pull request Dec 6, 2024
@BorysTheDev
Revert "refactor: remove redundant allocations for streamer (#4225)"
99bf184 
This reverts commit 071e299.
BorysTheDev added a commit that referenced this pull request Dec 6, 2024
@BorysTheDev
Revert "refactor: remove redundant allocations for streamer (#4225)"
75b1bc9 
This reverts commit 071e299.
BorysTheDev added a commit that referenced this pull request Dec 6, 2024
@BorysTheDev
Revert "refactor: remove redundant allocations for streamer (#4225)"
b088aaf 
This reverts commit 071e299.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chakaz chakaz chakaz approved these changes

@adiholden adiholden Awaiting requested review from adiholden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Journal streamer pending_buf_ redundant allocations
2 participants
@BorysTheDev @chakaz