Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DownloadPersistentCachePiece and SyncPersistentCachePieces api #447

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request introduces new functionalities to the dfdaemon API and updates the version of the dragonfly-api package. The most significant changes include the addition of new message types and RPC methods for handling persistent cache pieces, as well as updates to the corresponding client and server interfaces.

New functionalities for handling persistent cache pieces:

  • pkg/apis/dfdaemon/v2/dfdaemon.proto: Added new message types SyncPersistentCachePiecesRequest, SyncPersistentCachePiecesResponse, DownloadPersistentCachePieceRequest, and DownloadPersistentCachePieceResponse. Also added new RPC methods SyncPersistentCachePieces and DownloadPersistentCachePiece to the DfdaemonUpload service. [1] [2]
  • pkg/apis/dfdaemon/v2/dfdaemon_grpc.pb.go: Updated the DfdaemonUploadClient and DfdaemonUploadServer interfaces to include new methods for syncing and downloading persistent cache pieces. Added corresponding handler functions and updated the service description. [1] [2] [3] [4] [5] [6] [7]
  • proto/dfdaemon.proto: Added new message types and RPC methods for handling persistent cache pieces, mirroring the changes in dfdaemon.proto. [1] [2]
  • src/dfdaemon.v2.rs: Updated the Rust client and server code to include new methods for syncing and downloading persistent cache pieces. [1] [2] [3]

Version update:

  • Cargo.toml: Updated the version of the dragonfly-api package from 2.1.9 to 2.1.10.

Related Issue

Motivation and Context

@gaius-qi gaius-qi added the enhancement New feature or request label Jan 20, 2025
@gaius-qi gaius-qi self-assigned this Jan 20, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner January 20, 2025 04:05
@gaius-qi gaius-qi merged commit 161f9d8 into main Jan 20, 2025
6 checks passed
@gaius-qi gaius-qi deleted the feature/persistent-piece branch January 20, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant