bug: Remove download server UDS file on client startup if UDS file al… #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
=======================================
Coverage 32.66% 32.66%
=======================================
Files 60 60
Lines 9792 9792
=======================================
Hits 3199 3199
Misses 6593 6593
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ready exists...
On dfdaemon startup, check if the UDS file exists. If it does, remove it.
This helps in the cases where dfdaemon process has a non-graceful tear down and the UDS is mounted on hostpath. When dfdaemon restarts, it will never be able to bind to the UDS. Update the start up to check and delete the UDS if it exists...
Description
^
Related Issue
dragonflyoss/dragonfly#3782
Motivation and Context
Allows us to gracefully handle unexpected restarts.
Screenshots (if appropriate)