Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tokens page e2e test #329

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Dec 5, 2023

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@Liam-Zhao Liam-Zhao added the enhancement New feature or request label Dec 5, 2023
@Liam-Zhao Liam-Zhao self-assigned this Dec 5, 2023
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner December 5, 2023 08:43
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #329 (4e4406b) into main (36f588f) will increase coverage by 3.74%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   48.18%   51.93%   +3.74%     
==========================================
  Files          28       28              
  Lines        2839     2817      -22     
  Branches      809      791      -18     
==========================================
+ Hits         1368     1463      +95     
+ Misses       1470     1352     -118     
- Partials        1        2       +1     
Files Coverage Δ
src/components/developer/tokens/index.tsx 79.79% <100.00%> (+79.79%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 4d95cfb into main Dec 5, 2023
8 checks passed
@gaius-qi gaius-qi deleted the feat--add-tokens-page-e2e-test branch December 5, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants