Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page bug #432

Merged
merged 5 commits into from
Dec 30, 2024
Merged

fix: page bug #432

merged 5 commits into from
Dec 30, 2024

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Dec 30, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: zhaoxinxin <[email protected]>
@Liam-Zhao Liam-Zhao requested a review from gaius-qi December 30, 2024 08:08
@Liam-Zhao Liam-Zhao self-assigned this Dec 30, 2024
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner December 30, 2024 08:08
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (57803a5) to head (2ab279a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   98.08%   98.10%   +0.02%     
==========================================
  Files          39       39              
  Lines        4276     4276              
  Branches     1369     1405      +36     
==========================================
+ Hits         4194     4195       +1     
+ Misses         72       71       -1     
  Partials       10       10              
Files with missing lines Coverage Δ
src/components/clusters/index.tsx 95.09% <ø> (ø)
src/components/clusters/peers/index.tsx 98.07% <100.00%> (ø)
src/components/clusters/schedulers/index.tsx 98.19% <ø> (ø)
src/components/clusters/schedulers/show.tsx 98.38% <100.00%> (ø)
src/components/clusters/seed-peers/index.tsx 98.97% <ø> (ø)
src/components/clusters/seed-peers/show.tsx 98.36% <100.00%> (ø)
src/components/clusters/show.tsx 95.65% <ø> (ø)
src/components/developer/tokens/index.tsx 97.34% <ø> (ø)
src/components/job/preheats/index.tsx 100.00% <ø> (ø)
src/components/job/preheats/new.tsx 99.43% <ø> (ø)
... and 5 more

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 4252f20 into main Dec 30, 2024
8 checks passed
@gaius-qi gaius-qi deleted the fix--page-bug branch December 30, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants