-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action: update rust-cache and setup-go version #1498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. update Swatinem/rust-cache to v2.7.0. 2. share caches betwwen jobs in release, smoke, convert and benchmark. 3. save rust cache only in master branch in smoke test. Signed-off-by: Yadong Ding <[email protected]>
When update setup-go to v4, it can cache by itself. And select go version by `go.work`. Signed-off-by: Yadong Ding <[email protected]>
Desiki-high
requested review from
bergwolf,
liubogithub and
gaius-qi
and removed request for
a team
November 30, 2023 05:15
Desiki-high
changed the title
acrion: update rust-cache and setup-go version
action: update rust-cache and setup-go version
Nov 30, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1498 +/- ##
==========================================
+ Coverage 62.72% 62.75% +0.03%
==========================================
Files 123 123
Lines 43340 43340
Branches 43340 43340
==========================================
+ Hits 27183 27199 +16
+ Misses 14842 14827 -15
+ Partials 1315 1314 -1 |
Nydus-build is slow because of the new cache name, it will be faster next time. |
Desiki-high
force-pushed
the
deps/updates-action
branch
from
November 30, 2023 05:25
e0942b2
to
c3c28ec
Compare
adamqqqplay
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
imeoer
reviewed
Nov 30, 2023
imeoer
reviewed
Nov 30, 2023
Desiki-high
added a commit
to Desiki-high/nydus
that referenced
this pull request
Dec 1, 2023
Since dragonflyoss#1498, we will never save caches in pr, so we don't need clean-cache. Signed-off-by: Yadong Ding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
N/A
Details
shared-key: Linux-cargo-amd64
, especially between release and smoke.setup-go@v4
cache and select go version bygo.work
.Smoke Test
in pr, only save the rust-cache inmaster
.Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.