Update underlying native lib as tongsuo8.4(openssl3.0) #27
+54
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleil
reviewed
Aug 15, 2023
testing/src/main/java/org/conscrypt/tlswire/handshake/EllipticCurvesHelloExtension.java
Show resolved
Hide resolved
| @@ -960,6 +963,7 @@ public void test_SSLSocket_sendsTlsFallbackScsv_Fallback_Success() throws Except | |||
| } | |||
|
|
|||
| // Confirms that communication without the TLS_FALLBACK_SCSV cipher works as it always did. | |||
| @Ignore("Without the TLS_FALLBACK_SCSV cipher, it doesn't work in openssl 3.0") | |||
There was a problem hiding this comment.
支持OpenSSL3后，还需要继续维护基于OpenSSL1的版本。所以这些测试能否只对OpenSSL3 Ignore？
Sere-Fu
reviewed
Aug 15, 2023
common/src/test/java/org/conscrypt/javax/net/ssl/SSLSocketTest.java
Outdated
Show resolved
Hide resolved
superajun-wsj
force-pushed
the
update-dragonwell-security-provider-tongsuo8.4
branch
from
b6e3ae8
to
bf058d5
Compare
superajun-wsj
force-pushed
the
update-dragonwell-security-provider-tongsuo8.4
branch
from
bf058d5
to
cfd7f47
Compare
yuleil
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.