[Wisp] Port WispCounterMXBean and PerfCounterMonitor to JDK17. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The change is to port WispCounterMXBean and PerfCounterMonitor. But since JDK11 introduces module, there are the below changes: 1. move WispCounterMXBean and WispCounterMXBeanImpl into jdk.management 2. use PrintStream instead of Logging in WispPerfCounterMonitor 3. put WispCounter map in WispEngine instead of WispCounterMXBeanImpl 4. Restricted to module in JDK11, introduce WispCounterData for MXBean Test Plan: test/jdk/com/alibaba/wisp/TestWispCounter.java test/jdk/com/alibaba/wisp/TestWispDetailCounter.java test/jdk/com/alibaba/wisp2/TestProfileWithHandOff.java test/jdk/com/alibaba/wisp/TestWispMonitorData.java Reviewed-by: yulei Issue: dragonwell-project#97
yuleil
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The change is to port WispCounterMXBean and PerfCounterMonitor. But since JDK11 introduces module, there are the below changes:
Test Plan:
test/jdk/com/alibaba/wisp/TestWispCounter.java
test/jdk/com/alibaba/wisp/TestWispDetailCounter.java test/jdk/com/alibaba/wisp2/TestProfileWithHandOff.java test/jdk/com/alibaba/wisp/TestWispMonitorData.java
Reviewed-by: yulei
Issue:
#97