Use full namespace path for Lexicon values #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bookhive can be blamed for this PR ;)
Bookhive has a namespace and record value that caused FFSourceGen to break, since
Buzz.Bookhive.Buzzwould conflict with theBuzzrecord type they added. It would make more sense for the source generator to be very specific about the namespace rather than rely on that it's inside theFishyflip.Lexiconnamespace anyway.This also exposed that I really really need to clean up FFSourceGen to make it easier to update, half of these values are generated in two or three places that should be reduced to one.