-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Support #16
Docker Support #16
Conversation
@yash-chudasama is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
Fixes issue #11 |
This only partially implements #11. Requested is to have a docker image, not just the Dockerfile so it can be build locally. It additionally requires a bit of CI action to automatically build and push it to a registry (e.g. Dockerhub or GCR) upon new tag or release, which probably has to be discussed with the maintainer. |
@ToshY true but this is a great first step! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yash-chudasama, thank you for the PR :)
I tried running the container and when the page gets reloaded or a new window is opened the nginx server throws a 404 error. Could you please look into it? Maybe check out this thread.
Also I would really appreciate if you could fix the comments not to include NextJS since it's a simple react app.
Thank you so much!
Kindly add the below line as part of the NGINX step
this will ensure that all the routes will respond with index.html if the file were not found |
I would love to have this image available via a registry. |
I've updated the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This Pull Request makes the following changes
[Feature] Docker image #11
Changes