Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Support #16

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Docker Support #16

merged 2 commits into from
Apr 11, 2024

Conversation

yash-chudasama
Copy link
Contributor

@yash-chudasama yash-chudasama commented Apr 7, 2024

This Pull Request makes the following changes

Changes

  • Added Dockerfile
  • Updated documentation in README.md file

Copy link

vercel bot commented Apr 7, 2024

@yash-chudasama is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

@yash-chudasama yash-chudasama changed the title Resolves issue #11 Docker Support Apr 7, 2024
@yash-chudasama
Copy link
Contributor Author

Fixes issue #11

@ToshY
Copy link

ToshY commented Apr 7, 2024

This only partially implements #11. Requested is to have a docker image, not just the Dockerfile so it can be build locally. It additionally requires a bit of CI action to automatically build and push it to a registry (e.g. Dockerhub or GCR) upon new tag or release, which probably has to be discussed with the maintainer.

@jonas-grgt
Copy link
Contributor

@ToshY true but this is a great first step!

Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yash-chudasama, thank you for the PR :)

I tried running the container and when the page gets reloaded or a new window is opened the nginx server throws a 404 error. Could you please look into it? Maybe check out this thread.

Also I would really appreciate if you could fix the comments not to include NextJS since it's a simple react app.

Thank you so much!

@PRITHIVEE
Copy link

PRITHIVEE commented Apr 9, 2024

@yash-chudasama

Kindly add the below line as part of the NGINX step

RUN echo 'server { listen 80; server_name _; root /usr/share/nginx/html; location / { try_files $uri /index.html; } }' > /etc/nginx/conf.d/default.conf

this will ensure that all the routes will respond with index.html if the file were not found

@DenuxPlays
Copy link
Contributor

I would love to have this image available via a registry.
If that's something you want to implement I could make the github workflow.

@yash-chudasama
Copy link
Contributor Author

RUN echo 'server { listen 80; server_name _; root /usr/share/nginx/html; location / { try_files $uri /index.html; } }' > /etc/nginx/conf.d/default.conf

I've updated the same.

Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@1ilit 1ilit merged commit 1f78ba8 into drawdb-io:main Apr 11, 2024
2 of 3 checks passed
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 2:57am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants