-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(facade): separated to plugins to be composable #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
wzhudev
force-pushed
the
refactor/facade-extend
branch
from
October 12, 2024 11:51
4841337
to
b28b6ef
Compare
wzhudev
force-pushed
the
refactor/facade-extend
branch
from
October 12, 2024 12:15
b28b6ef
to
c7cf854
Compare
BREAKING CHANGE: filter commands have been moved to sheets-filter
wzhudev
force-pushed
the
refactor/facade-extend
branch
from
October 14, 2024 07:39
1f08ad8
to
539880b
Compare
wzhudev
force-pushed
the
refactor/facade-extend
branch
from
October 14, 2024 08:11
6de288c
to
64aced9
Compare
wzhudev
changed the title
refactor(facade): refactor facade
refactor(facade): separate facade to plugins to make it composable
Oct 14, 2024
wzhudev
changed the title
refactor(facade): separate facade to plugins to make it composable
refactor(facade): separated to plugins to make it composable
Oct 14, 2024
wzhudev
changed the title
refactor(facade): separated to plugins to make it composable
refactor(facade): separated to plugins to be composable
Oct 14, 2024
wzhudev
force-pushed
the
refactor/facade-extend
branch
from
October 14, 2024 09:07
8009116
to
fd9a004
Compare
Playwright test resultsDetails 19 tests across 9 suites |
@jikkai We need config |
wzhudev
force-pushed
the
refactor/facade-extend
branch
2 times, most recently
from
October 14, 2024 13:26
2da8bd8
to
39ce223
Compare
lumixraku
force-pushed
the
refactor/facade-extend
branch
from
October 26, 2024 13:10
ad28896
to
3822548
Compare
4 tasks
wzhudev
force-pushed
the
refactor/facade-extend
branch
from
October 28, 2024 09:22
6433a0d
to
a26a6f6
Compare
wzhudev
requested review from
ybzky,
yuhongz,
Gggpound,
Dushusir,
siam-ese,
Jocs,
jikkai,
VicKun4937,
hexf00 and
lumixraku
as code owners
October 29, 2024 12:29
jikkai
approved these changes
Oct 30, 2024
Gggpound
pushed a commit
that referenced
this pull request
Oct 30, 2024
Co-authored-by: 白熱 <[email protected]> Co-authored-by: lumixraku <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
In order to support Node.js SDK, we made some fundamental changes to our codebase. Please note the following breaking changes:
@univerjs/facade
and@univerjs-pro/facade
are marked as deprecated and will be removed in 0.6.0. Please refer to the guide on our official website for more details.Pull Request Checklist