Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(facade): separated to plugins to be composable #3730

Merged
merged 48 commits into from
Oct 30, 2024
Merged

refactor(facade): separated to plugins to be composable #3730

merged 48 commits into from
Oct 30, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 12, 2024 •
edited
Loading

BREAKING CHANGES:

In order to support Node.js SDK, we made some fundamental changes to our codebase. Please note the following breaking changes:

  • sheets-numfmt package has been split into two packages: sheets-numfmt and sheets-numfmt-ui. Please include both of them in your applications.
  • sheets-thread-comment-base bas been renamed to sheets-thread-comment, and sheets-thread-comment has been renamed to sheets-thread-comment-ui. Please include both of them in your applications.
  • Facade API has been separated to plugins so they can be composable. The legacy @univerjs/facade and @univerjs-pro/facade are marked as deprecated and will be removed in 0.6.0. Please refer to the guide on our official website for more details.

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 12, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev changed the title refactor(facade): refactor facade refactor(facade): separate facade to plugins to make it composable Oct 14, 2024
@wzhudev wzhudev changed the title refactor(facade): separate facade to plugins to make it composable refactor(facade): separated to plugins to make it composable Oct 14, 2024
@wzhudev wzhudev changed the title refactor(facade): separated to plugins to make it composable refactor(facade): separated to plugins to be composable Oct 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  25b0d68
info  For more information, see full report

@wzhudev
Copy link
Member Author

wzhudev commented Oct 14, 2024

@jikkai We need config sideEffect.

@wzhudev wzhudev force-pushed the refactor/facade-extend branch 2 times, most recently from 2da8bd8 to 39ce223 Compare October 14, 2024 13:26
@wzhudev wzhudev mentioned this pull request Oct 28, 2024
Closed
4 tasks
@wzhudev wzhudev marked this pull request as ready for review October 29, 2024 12:29
@wzhudev wzhudev added the 0.5.0 label Oct 29, 2024
@wzhudev wzhudev merged commit bc6a7bb into dev Oct 30, 2024
9 checks passed
@wzhudev wzhudev deleted the refactor/facade-extend branch October 30, 2024 03:35
Gggpound pushed a commit that referenced this pull request Oct 30, 2024
@wzhudev @jikkai
@lumixraku @Gggpound
refactor(facade): separated to plugins to be composable (#3730)
888f293 
Co-authored-by: 白熱 <[email protected]>
Co-authored-by: lumixraku <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jikkai jikkai jikkai approved these changes

@ybzky ybzky Awaiting requested review from ybzky ybzky is a code owner

@yuhongz yuhongz Awaiting requested review from yuhongz yuhongz is a code owner

@Gggpound Gggpound Awaiting requested review from Gggpound Gggpound is a code owner

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir is a code owner

@siam-ese siam-ese Awaiting requested review from siam-ese siam-ese is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

@VicKun4937 VicKun4937 Awaiting requested review from VicKun4937 VicKun4937 is a code owner

@hexf00 hexf00 Awaiting requested review from hexf00 hexf00 is a code owner

@lumixraku lumixraku Awaiting requested review from lumixraku lumixraku is a code owner

Assignees
No one assigned
Labels
0.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wzhudev @jikkai @lumixraku