-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(formula): fix progress bar not loaded #3790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
wzhudev
force-pushed
the
fix/sheet-progress
branch
from
October 18, 2024 03:48
c9528b0
to
323fde1
Compare
Playwright test resultsDetails 19 tests across 9 suites |
Dushusir
force-pushed
the
fix/sheet-progress
branch
from
October 18, 2024 08:30
323fde1
to
52d50fc
Compare
Dushusir
force-pushed
the
fix/sheet-progress
branch
from
October 18, 2024 12:41
975ebea
to
5752a1e
Compare
Dushusir
force-pushed
the
fix/sheet-progress
branch
2 times, most recently
from
October 19, 2024 12:14
57f2327
to
e4dc574
Compare
Dushusir
changed the title
fix: fix progress bar not loaded
fix(formula): fix progress bar not loaded
Oct 21, 2024
Dushusir
added
qa:untested
This PR is ready to be tested
and removed
qa:untested
This PR is ready to be tested
labels
Oct 21, 2024
Dushusir
force-pushed
the
fix/sheet-progress
branch
from
October 21, 2024 13:10
cba6782
to
a9d5579
Compare
Dushusir
force-pushed
the
fix/sheet-progress
branch
5 times, most recently
from
October 24, 2024 07:19
b81c9da
to
7a1c39f
Compare
Dushusir
force-pushed
the
fix/sheet-progress
branch
from
October 24, 2024 07:45
09c5a98
to
ce3e629
Compare
zhaolixin7
added
the
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
label
Oct 24, 2024
VicKun4937
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
Dushusir
force-pushed
the
fix/sheet-progress
branch
from
October 24, 2024 10:41
ce3e629
to
eef03a1
Compare
DR-Univer
approved these changes
Oct 25, 2024
Dushusir
force-pushed
the
fix/sheet-progress
branch
from
October 26, 2024 02:53
eef03a1
to
5cd07ab
Compare
Dushusir
force-pushed
the
fix/sheet-progress
branch
from
October 26, 2024 06:22
5cd07ab
to
cd8d10a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IProgressService
deserializeRangeWithSheet
withdeserializeRangeWithSheetWithCache
intervalCount
for formula engine. The formula calculation quantity interval for waiting for the main thread message in the worker. Each time the formula calculates theintervalCount
quantity, it will receive a main thread message to support stopping the calculation. Default is 500.How to test?
Import a table with 500,000 formulas and check if a progress bar appears (it will take about 10 seconds to calculate)
Pull Request Checklist