Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): fix progress bar not loaded #3790

Merged
merged 17 commits into from
Oct 26, 2024
Merged

fix(formula): fix progress bar not loaded #3790

merged 17 commits into from
Oct 26, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 18, 2024

  • Remove IProgressService
  • Replace deserializeRangeWithSheet with deserializeRangeWithSheetWithCache
  • add config intervalCount for formula engine. The formula calculation quantity interval for waiting for the main thread message in the worker. Each time the formula calculates the intervalCount quantity, it will receive a main thread message to support stopping the calculation. Default is 500.

How to test?

Import a table with 500,000 formulas and check if a progress bar appears (it will take about 10 seconds to calculate)

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 18, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  cd8d10a
info  For more information, see full report

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 18.36735% with 200 lines in your changes missing coverage. Please review.

Project coverage is 31.97%. Comparing base (1ab5eff) to head (cd8d10a).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...formula/src/services/dependency-manager.service.ts 26.47% 50 Missing ⚠️
.../src/controllers/trigger-calculation.controller.ts 0.00% 43 Missing ⚠️
...ges/ui/src/components/progress-bar/ProgressBar.tsx 0.00% 30 Missing ⚠️
...-formula/src/services/calculate-formula.service.ts 3.84% 25 Missing ⚠️
packages/core/src/shared/r-tree.ts 0.00% 17 Missing ⚠️
...-ui/src/views/formula-progress/FormulaProgress.tsx 0.00% 9 Missing ⚠️
...ges/engine-formula/src/services/runtime.service.ts 12.50% 7 Missing ⚠️
...ges/sheets-ui/src/views/formula-bar/FormulaBar.tsx 0.00% 4 Missing ⚠️
...ormula/src/engine/dependency/formula-dependency.ts 57.14% 3 Missing ⚠️
...ine-formula/src/controller/calculate.controller.ts 0.00% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3790      +/-   ##
==========================================
- Coverage   31.99%   31.97%   -0.03%     
==========================================
  Files        2353     2353              
  Lines      121389   121378      -11     
  Branches    26877    26856      -21     
==========================================
- Hits        38833    38805      -28     
- Misses      82556    82573      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev marked this pull request as draft October 19, 2024 07:09
@Dushusir Dushusir force-pushed the fix/sheet-progress branch 2 times, most recently from 57f2327 to e4dc574 Compare October 19, 2024 12:14
@Dushusir Dushusir marked this pull request as ready for review October 21, 2024 02:56
@Dushusir Dushusir changed the title fix: fix progress bar not loaded fix(formula): fix progress bar not loaded Oct 21, 2024
@Dushusir Dushusir added qa:untested This PR is ready to be tested and removed qa:untested This PR is ready to be tested labels Oct 21, 2024
@Dushusir Dushusir marked this pull request as draft October 21, 2024 07:45
@Dushusir Dushusir marked this pull request as ready for review October 21, 2024 13:17
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Oct 22, 2024
@Dushusir Dushusir force-pushed the fix/sheet-progress branch 5 times, most recently from b81c9da to 7a1c39f Compare October 24, 2024 07:19
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 24, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 24, 2024
Copy link
Contributor

@VicKun4937 VicKun4937 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@Dushusir Dushusir merged commit 065dadc into dev Oct 26, 2024
9 checks passed
@Dushusir Dushusir deleted the fix/sheet-progress branch October 26, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants