Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auto col #3798

Merged
merged 6 commits into from
Oct 29, 2024
Merged

feat: auto col #3798

merged 6 commits into from
Oct 29, 2024

Conversation

lumixraku
Copy link
Contributor

close https://github.com/dream-num/univer-pro/issues/2912

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 33 seconds
commit  2999b6a
info  For more information, see full report

@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.90476% with 412 lines in your changes missing coverage. Please review.

Project coverage is 31.89%. Comparing base (448d32c) to head (2999b6a).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 126 Missing ⚠️
...der-controllers/header-resize.render-controller.ts 0.00% 120 Missing ⚠️
...validation-ui/src/views/widgets/dropdown-widget.ts 0.00% 34 Missing ⚠️
...sheets-ui/src/controllers/auto-width.controller.ts 9.09% 30 Missing ⚠️
...s/commands/set-worksheet-auto-col-width.command.ts 4.00% 24 Missing ⚠️
...mmands/commands/set-worksheet-col-width.command.ts 4.00% 24 Missing ⚠️
...n-ui/src/views/widgets/dropdown-multiple-widget.ts 0.00% 18 Missing ⚠️
...ne-render/src/components/sheets/extensions/font.ts 0.00% 10 Missing ⚠️
...idation-ui/src/controllers/dv-render.controller.ts 0.00% 8 Missing ⚠️
...ta-validation-ui/src/views/widgets/shape/layout.ts 0.00% 6 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #3798      +/-   ##
==========================================
- Coverage   31.95%   31.89%   -0.07%     
==========================================
  Files        2353     2355       +2     
  Lines      121426   121690     +264     
  Branches    26866    26927      +61     
==========================================
+ Hits        38805    38813       +8     
- Misses      82621    82877     +256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the feat/auto-col branch 2 times, most recently from e8ec962 to 0629d61 Compare October 18, 2024 12:14
@lumixraku lumixraku marked this pull request as draft October 19, 2024 06:47
@lumixraku lumixraku force-pushed the feat/auto-col branch 7 times, most recently from 955e0e5 to 7e6e871 Compare October 23, 2024 07:10
@lumixraku lumixraku marked this pull request as ready for review October 23, 2024 07:35
@lumixraku lumixraku force-pushed the feat/auto-col branch 2 times, most recently from b182b19 to f993a7c Compare October 23, 2024 13:04
wzhudev
wzhudev requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this PR looks great to me. Some code readability issue and misspelling can be fixed to improve code quality.

packages/engine-render/src/components/sheets/sheet-skeleton.ts Outdated Show resolved Hide resolved
packages/engine-render/src/components/sheets/sheet-skeleton.ts Outdated Show resolved Hide resolved
packages/engine-render/src/components/sheets/sheet-skeleton.ts Show resolved Hide resolved
packages/engine-render/src/components/sheets/sheet-skeleton.ts Outdated Show resolved Hide resolved
@lumixraku lumixraku force-pushed the feat/auto-col branch 2 times, most recently from fcc2cac to 7381217 Compare October 24, 2024 07:29
@lumixraku lumixraku added the qa:untested This PR is ready to be tested label Oct 24, 2024
@lumixraku
Copy link
Contributor Author

测试样张
auto-col.json

@univer-bot
Copy link

univer-bot bot commented Oct 26, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Test sample
auto-col.json

@lumixraku lumixraku force-pushed the feat/auto-col branch 2 times, most recently from 9b3f0cb to 4be175e Compare October 28, 2024 03:04
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 28, 2024
@univer-bot univer-bot bot removed the qa:rejected label Oct 28, 2024
@lumixraku lumixraku force-pushed the feat/auto-col branch 5 times, most recently from f005f13 to 216967f Compare October 28, 2024 12:35
@lumixraku
fix: skeleton limit col when setStylesCache
8c70683
@lumixraku
feat: add auto width controller
6e84b5f 
feat: check row around visible range width for auto col width

chore: better code

fix: support mutiple auto col width

fix: no need auto width param
@lumixraku
fix: use set col width mutation, no need add set col auto width mutation
1879613
@lumixraku
fix: font left offset because of leftOffset
150a579 
feat: add auto col for dv render
@lumixraku
chore: better code
d89454f 
chore(snapshots): update snapshots

chore: better code
@lumixraku lumixraku force-pushed the feat/auto-col branch 2 times, most recently from cda3fa3 to 78079b6 Compare October 29, 2024 03:04
@lumixraku
fix: mv auto col cmd into sheets-ui
2999b6a 
chore(snapshots): update snapshots

fix: mv auto col cmd into sheets-ui
wzhudev
wzhudev approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumixraku lumixraku merged commit c66cff0 into dev Oct 29, 2024
9 checks passed
@lumixraku lumixraku deleted the feat/auto-col branch October 29, 2024 04:09
Gggpound pushed a commit that referenced this pull request Oct 30, 2024
@lumixraku @Gggpound
feat: auto col (#3798)
1a2077a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VicKun4937 VicKun4937 VicKun4937 left review comments

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

@yuhongz yuhongz Awaiting requested review from yuhongz yuhongz is a code owner

@weird94 weird94 Awaiting requested review from weird94 weird94 is a code owner

Assignees

@lumixraku lumixraku

Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lumixraku @oumomomo @VicKun4937 @wzhudev