Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): doc select all content and remove when has tables #3800

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Oct 19, 2024

close https://github.com/dream-num/univer-pro/issues/2938

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review October 19, 2024 03:57
@Jocs Jocs requested a review from jikkai as a code owner October 19, 2024 03:57
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 19, 2024
Copy link

github-actions bot commented Oct 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 19, 2024

Playwright test results

failed  1 failed
passed  18 passed

Details

stats  19 tests across 9 suites
duration  5 minutes, 10 seconds
commit  447b33d
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-gridlines.spec.ts › sheets no gridlines

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 31.97%. Comparing base (caed6de) to head (447b33d).

Files with missing lines Patch % Lines
...ui/src/commands/commands/doc-select-all.command.ts 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3800      +/-   ##
==========================================
- Coverage   31.97%   31.97%   -0.01%     
==========================================
  Files        2350     2350              
  Lines      121203   121213      +10     
  Branches    26822    26825       +3     
==========================================
- Hits        38755    38754       -1     
- Misses      82448    82459      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo
Copy link

在文档内添加两个表格后全选表格+内容进行删除,页面白屏
表格添加的位置如截图
image
2024_10_19 16_05_44 video.webm

@univer-bot
Copy link

univer-bot bot commented Oct 19, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

After adding two tables in the document, select all tables + content to delete, and the page will go blank.
The location where the table is added is as shown in the screenshot
image
2024_10_19 16_05_44 video.webm

@dream-num dream-num deleted a comment from univer-bot bot Oct 19, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants