Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-hyper-link): link ref range behavior error #3862

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Oct 26, 2024

close https://github.com/dream-num/univer-pro/issues/3033

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 26, 2024
Copy link

github-actions bot commented Oct 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 26, 2024

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 10 seconds
commit  9c4882a
info  For more information, see full report

Flaky tests

chromium › visual-comparison/sheets/sheets-gridlines.spec.ts › sheets no gridlines

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.99%. Comparing base (5fcd97a) to head (9c4882a).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
.../src/controllers/rich-text-ref-range.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3862      +/-   ##
==========================================
+ Coverage   31.98%   31.99%   +0.01%     
==========================================
  Files        2353     2353              
  Lines      121359   121363       +4     
  Branches    26865    26864       -1     
==========================================
+ Hits        38812    38833      +21     
+ Misses      82547    82530      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 26, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Oct 26, 2024
@weird94 weird94 merged commit 3126112 into dev Oct 26, 2024
9 checks passed
@weird94 weird94 deleted the fix/link-ref-range branch October 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants