Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): line break in collaboration #3863

Merged
merged 3 commits into from
Oct 26, 2024
Merged

fix(docs): line break in collaboration #3863

merged 3 commits into from
Oct 26, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Oct 26, 2024

close https://github.com/dream-num/univer-pro/issues/2941

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 26, 2024

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 9 seconds
commit  98c0fff
info  For more information, see full report

Flaky tests

chromium › visual-comparison/sheets/sheets-gridlines.spec.ts › sheets no gridlines

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 31.96%. Comparing base (e99aec1) to head (98c0fff).

Files with missing lines Patch % Lines
...ocs-ui/src/commands/commands/break-line.command.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3863      +/-   ##
==========================================
- Coverage   31.97%   31.96%   -0.01%     
==========================================
  Files        2353     2353              
  Lines      121379   121380       +1     
  Branches    26858    26859       +1     
==========================================
  Hits        38805    38805              
- Misses      82574    82575       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review October 26, 2024 06:42
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Oct 26, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Oct 26, 2024
@Jocs Jocs merged commit e95449e into dev Oct 26, 2024
2 checks passed
@Jocs Jocs deleted the fix/line-break branch October 26, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants