-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cell): fix cell string type #3872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpxp123456
requested review from
Gggpound,
Jocs,
jikkai and
wzhudev
as code owners
October 28, 2024 12:00
View Deployment
|
Playwright test resultsDetails 19 tests across 9 suites |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3872 +/- ##
==========================================
- Coverage 31.89% 31.89% -0.01%
==========================================
Files 2355 2355
Lines 121690 121694 +4
Branches 26927 26928 +1
==========================================
- Hits 38813 38811 -2
- Misses 82877 82883 +6 ☔ View full report in Codecov by Sentry. |
wpxp123456
force-pushed
the
fix/cell-string-type
branch
from
October 29, 2024 03:41
dacabec
to
929030c
Compare
wpxp123456
force-pushed
the
fix/cell-string-type
branch
from
October 29, 2024 06:28
582f1cb
to
c9b4dfc
Compare
oumomomo
added
the
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
label
Oct 29, 2024
Dushusir
approved these changes
Oct 29, 2024
Gggpound
pushed a commit
that referenced
this pull request
Oct 30, 2024
Co-authored-by: wpxp123456 <Wpxp1223456>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3675
Pull Request Checklist