Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sheet drawing commands support intercepting mutations #3885

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Oct 29, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 32 seconds
commit  a1a5d5e
info  For more information, see full report

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 31.97%. Comparing base (31e58f0) to head (a1a5d5e).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
.../commands/commands/insert-sheet-drawing.command.ts 0.00% 5 Missing ⚠️
.../commands/commands/remove-sheet-drawing.command.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3885      +/-   ##
==========================================
- Coverage   31.97%   31.97%   -0.01%     
==========================================
  Files        2359     2359              
  Lines      121801   121809       +8     
  Branches    26933    26933              
==========================================
  Hits        38949    38949              
- Misses      82852    82860       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuhongz yuhongz merged commit 7f1cf91 into dev Oct 30, 2024
9 checks passed
@yuhongz yuhongz deleted the feat/chart-drawing-adp branch October 30, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants