Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: optimize UMD build and remove CJS build steps #3895

Merged
merged 1 commit into from
Oct 30, 2024
Merged

build: optimize UMD build and remove CJS build steps #3895

merged 1 commit into from
Oct 30, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Oct 30, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 30, 2024

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 7 seconds
commit  89823b2
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.95%. Comparing base (f007660) to head (89823b2).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...kages/sheets-hyper-link-ui/src/controllers/menu.ts 0.00% 1 Missing ⚠️
...heets-ui/src/views/permission/panel-list/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3895   +/-   ##
=======================================
  Coverage   30.95%   30.95%           
=======================================
  Files        2387     2387           
  Lines      122062   122062           
  Branches    27005    27005           
=======================================
  Hits        37787    37787           
  Misses      84275    84275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai force-pushed the build/umd branch 2 times, most recently from f6972d6 to e0fecc4 Compare October 30, 2024 12:03
@jikkai jikkai merged commit 91f4812 into dev Oct 30, 2024
9 checks passed
@jikkai jikkai deleted the build/umd branch October 30, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant