fix(sheet): support read default style when create editor #4540
Conversation
VicKun4937
commented
Jan 21, 2025
VicKun4937
commented
- in editor , the default style should be read
View Deployment
|
Playwright test results
Details
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4540 +/- ##
==========================================
- Coverage 32.58% 32.58% -0.01%
==========================================
Files 2610 2610
Lines 136048 136057 +9
Branches 30270 30272 +2
==========================================
Hits 44331 44331
- Misses 91717 91726 +9 ☔ View full report in Codecov by Sentry. |
| @@ -1532,7 +1538,7 @@ export class SpreadsheetSkeleton extends Skeleton { | |||
| ...options, | |||
| }; | |||
|
|
|||
| const style = this._styles.getStyleByCell(cell); | |||
| const style = { ...options.cellDefaultStyle, ...this._styles.getStyleByCell(cell) }; | |||
There was a problem hiding this comment.
When should we use composeStyles, and when to use the extend operator?
|
|
||
| documentLayoutObject = cell && skeleton.getCellDocumentModelWithFormula(cell); | ||
| documentLayoutObject = cell && skeleton.getCellDocumentModelWithFormula(cell, cellDefaultStyle); |
There was a problem hiding this comment.
Is this the only place that cellDefaultStyle should be passed? getCellDocumentModelWithFormula are called in other situations such as removing cell hyperlink.
|
this pr seems not necessary one, considering close it. |
Have you made a conclusion here? Shall we close it? |
wpxp123456
force-pushed
the
fix-default-style-unread
branch
from
f13c202 to
ea402ea
Compare
