Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPCP-3] Add websockets #2

Merged
merged 197 commits into from
May 12, 2024
Merged

[DPCP-3] Add websockets #2

merged 197 commits into from
May 12, 2024

Conversation

angeloreale
Copy link
Collaborator

@angeloreale angeloreale commented May 11, 2024

PLEASE REVIEW YOUR OWN PR BEFORE OPENING/UN-DRAFTING IT

[DPCP-3] Add websockets

This PR adds server->client communication sockets.
It also gets rid of any headful/client Next.js stuff.
Migrated from @dreampipcom/nyx on 12.05.2024

Have you?

  • Reviewed your own PR?
  • Tested your own feature/fix meets Acceptance Criteria?
  • Made sure it passes all checks? (lint, build, integrations, scripts, etc)?
  • Added unit tests? (if necessary)
  • Added documentation? (if necessary)

If so, THANKS! You can pop a beer/soda.

Please open your PR and ping your colleagues to review it on #web-devs channel.

Also, make sure to remind them on a daily basis during stand-up.

Copy link

Add websockets

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hypnos ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 1:14am

Copy link
Collaborator Author

@angeloreale angeloreale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angeloreale angeloreale merged commit a855969 into dev May 12, 2024
4 checks passed
@angeloreale
Copy link
Collaborator Author

Unfinished Sockets feature, but need to progress dev branch

@angeloreale angeloreale deleted the ar/chitty-chat branch August 7, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants