Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to poetry. Get rid of using pure pip #16

Closed
wants to merge 10 commits into from

Conversation

alexbojko
Copy link
Collaborator

Solves this issue #15

…code. Changes Docker file, compose files to work with new folders structure
@alexbojko alexbojko requested a review from aih April 20, 2022 18:30
@alexbojko alexbojko self-assigned this Apr 20, 2022
@aih
Copy link
Collaborator

aih commented Apr 23, 2022

@alexbojko I've updated the README and tested 'poetry install'. It works. However, it's not clear to me:
1- whether billtitleindex can now be used as a Python package and
2- if so, what does it contain? I see that I can run from billtitleindex import *, but I don't see what the structure is of that package (it doesn't seem to have a btiapp). Maybe we need to add the billtitleindex namespace for internal imports:

File "/Users/arihershowitz/Documents/workspace/billtitleindex/src/billtitleindex/btiapp/utils.py", line 11, in <module>
    from btiapp.models import BillBasic

Should this be from billtitleindex.btiapp.models import BillBasic?

@alexbojko
Copy link
Collaborator Author

you are right about from billtitleindex.btiapp.models import BillBasic

as a package it should be used exactly that way

@alexbojko alexbojko force-pushed the dev/migrate_to_poetry branch from 2275404 to 432c7b4 Compare May 5, 2022 02:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 20 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexbojko alexbojko linked an issue May 5, 2022 that may be closed by this pull request
@alexbojko alexbojko closed this Mar 14, 2023
@alexbojko
Copy link
Collaborator Author

no need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants