This repository has been archived by the owner on May 31, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds Deferred support to
time_calls
andhist_calls
by a wrapper function. Instead of updating the timer or updating with the result upon calling it (which, will be a Deferred, not an actual result), it tacks on a callback which does the updating instead. If the function does not return a Deferred, it calls the callback synchronously and returns the result as expected.I tested it in a virtualenv which had no Twisted and it worked, although I am not absolutely sure, but Travis should be able to tell us that.
All tests pass here - I'm not 100% sure how I can write tests that will work if Twisted isn't there, since it uses Trial... so I'm not sure if I just need to write some additional tests that assume Twisted is there?