Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic menu items #1004

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Use dynamic menu items #1004

merged 1 commit into from
Jan 8, 2025

Conversation

xoascf
Copy link
Collaborator

@xoascf xoascf commented Jan 8, 2025

Some XAML refactoring and updating of method names to "fix naming rule", updating of control names and event handler methods. This is a working, merge-ready part of #461, otherwise it will never get merged!

  • Updated control names in RetroBar/PropertiesWindow.xaml to use x:Name instead of Name for consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
  • Renamed AutoStartCheckBox control to cbAutoStart for consistency.
  • Renamed event handler methods in RetroBar/PropertiesWindow.xaml.cs to follow a consistent naming convention. [1] [2] [3]
  • Added new MenuItem resources and updated the context menu in RetroBar/Taskbar.xaml to use them as needed. [1] [2] [3]

This seems even closer to the XP behavior. Once the template is abstracted/detached/unhardcoded from the taskbar, it should also allow the use of custom menu items for the theme (so the user can customize items to hide or show them, apart from the Exit option in Properties).

Copy link
Owner

@dremin dremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One thing I noticed is the option to set time is no longer bold. However, XP and Vista don't have this bold, while earlier versions do. Maybe it should be theme-controllable.

@dremin dremin merged commit 317642e into dremin:master Jan 8, 2025
3 checks passed
@xoascf xoascf deleted the dynamic-menu-items branch January 8, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants