Multi-row functionality #928

Avid29 · 2024-10-17T04:32:43Z

Still a work in progress, but here's some screenshots:

Avid29 · 2024-10-17T05:17:54Z

Remaining tasks

Swap to large icon when the row count is greater than 1 (see Vista)
Fix unlocked mode glitches (especially prominent in XP Blue based styles)
Remove rounded corners when unlocked (side effect of ResizingMode="CanResize").
Keep row count in settings
Adjust style properties to explicitly handle row heights instead of assuming each row doubles the taskbar height
Allow resizing on sides and top

(Many were hot-fixed by replacing drag functionality with a settings option)

Avid29 · 2024-10-17T07:01:48Z

Here's every taskbar with 2 rows:

System

System XP

Watercolor

Windows 2000

Windows 95-98

Windows Longhorn Aero

Windows Me

Windows Vista Aero

Windows Vista Basic

Windows Vista Classic

Windows XP Blue

Windows XP Classic

Windows XP Embedded

Windows XP Olive Green

Windows XP Royale Noir

Windows XP Royale

Windows XP Silver

Windows XP Zune

Avid29 · 2024-10-17T07:23:34Z

Small update. The toolbar is now vertically centered (on every taskbar)

dremin · 2024-10-17T23:12:04Z

Hey, thanks, this is looking great so far! I am going to try to take a deeper look at this soon.

dremin

This is a great start! In addition to the items within the review comments, I noticed a few layout correctness issues:

Within the Toolbar and the NotifyIconList controls: The WrapPanel within should have its Orientation property changed to Vertical when the taskbar is in a horizontal orientation and has more than 1 row. It should remain Horizontal otherwise.
The classic Start button should not stretch vertically, it should keep its height and be aligned to the top. The XP start buttons should also be top aligned.
For the XP and newer themes, the clock should change to the extended format that is used when in a vertical orientation.

I didn't pixel peep so there may be some other minor issues to address as well, but let's see how it looks after these changes! :)

RetroBar/PropertiesWindow.xaml

RetroBar/Taskbar.xaml

RetroBar/Taskbar.xaml.cs

dremin · 2024-10-18T05:45:54Z

RetroBar/Themes/System.xaml

+        <Setter Property="VerticalAlignment"
+                Value="Center"/>


This isn't correct, the toolbars should keep their existing alignment. However, there is another related change that will need to be made for correctness, that I will comment separately on.

Shouldn't tray icons be aligned at top as well, like quick launch?

@1280px Yes, but that will require some more extensive theme changes.

Avid29 · 2024-10-18T14:22:59Z

Alignment changes made

Avid29 · 2024-10-18T14:42:57Z

I added the expanded clock, and it works great for System XP and Vista, but the padding is a bit messed up (especially on XP Blue)

Avid29 · 2024-10-18T17:33:45Z

I added the vertical orientation adjustment:

Based on this I have two proposals

Add padding
Flip the FlowDirection (and item order?)

ghost · 2024-10-28T08:31:52Z

Very nice work.
I have tested this version for a week now and it is very good.

1 thing that is missing is multirow functionality for the quicklaunch items, would that be possible to add? @Avid29
now the quicklaunch items are all in 1 row,

screenshot:

EDIT:
as a suqqestion, divide the amount of quicklaunch icons by the row amount:
2 rows 10 icons would then be 5 icons on each row,
3 rows and 12 icons would be 4 icons on each row... and so on.

Avid29 · 2024-10-29T01:17:42Z

@MKKNinetyTwo Done. Pushing now

ghost · 2024-10-29T03:50:18Z

@MKKNinetyTwo Done. Pushing now

This is perfect. Thanks!

screenshot:

dremin · 2024-10-29T05:28:12Z

RetroBar/Themes/Windows XP Blue.xaml

The clock alignment is off because of the margin on the Clock style (line 1597). If you adjust this style and trigger in the same manner as ClockTemplateKey that should take care of that issue.

dremin · 2024-10-29T06:00:49Z

RetroBar/Languages/English.xaml

@@ -20,6 +20,15 @@
        <s:String>Right</s:String>
        <s:String>Bottom</s:String>
    </x:Array>
+    <s:String x:Key="rowcount_text">Row Count:</s:String>


Let's change this to Number of _rows:

dremin · 2024-10-29T06:01:29Z

RetroBar/PropertiesWindow.xaml

@@ -203,6 +204,15 @@
                                          SelectedIndex="{Binding Source={x:Static Settings:Settings.Instance}, Path=Edge, UpdateSourceTrigger=PropertyChanged, Converter={StaticResource enumConverter}}"
                                          SelectionChanged="cboEdgeSelect_SelectionChanged" />
                            </DockPanel>
+                            <DockPanel IsEnabled="{Binding Source={x:Static Settings:Settings.Instance}, Path=Edge, Converter={StaticResource isHorizontalConverter}}">
+                                <Label VerticalAlignment="Center"
+                                       Target="{Binding ElementName=cboEdgeSelect}">


The Target of this Label needs to be fixed to point to the rows ComboBox.

dremin · 2024-10-29T06:02:05Z

Add padding

The padding and alignment of the tray icons will need some changes in a few themes. There are a few other sizing changes that will need to be made anyway. I'm okay making those minor changes later.

Flip the FlowDirection (and item order?)

I tested this and don't think it will do what we want, what are you looking to affect with this change?

Avid29 · 2024-10-30T00:19:53Z

Flip the FlowDirection (and item order?)

I tested this and don't think it will do what we want, what are you looking to affect with this change?

I haven't tested it yet, but I expect that if the number of items in the NotifyIconsList is not divisible by the number of rows the system clock side will have empty slots were items would be while the expected behavior is that they would fill in from that side. You'd also still expect the system icons (volume, network, and such) to be on the system clock side.

ghost · 2024-11-02T08:35:51Z

If someone wants these I made Finnish translation, and 2 custom Windows 7 themes.

These were made for Avid29 RetroBar_resizable_taskbar,
but should work on original RetroBar too.
Can be added to retrobar github if you want @dremin

Windows 7 Royale Noir (Vista theme base, Xp Royale Noir colors, Win7 startmenu):

Windows 7 Zune (Vista theme base, Xp Zune colors, Win7 startmenu):

Translation and themes:
EDIT: Finnish translation download removed, see Pull Request instead Avid29#1
https://www.mediafire.com/file/zkvruzec1ujrxqq/RetroBar_Windows_7_Custom_Themes.rar

1280px · 2024-11-02T09:50:35Z

@MKKNinetyTwo You can submit a translation through a separate pull request :)

ghost · 2024-11-02T10:11:21Z

@MKKNinetyTwo You can submit a translation through a separate pull request :)

I know, but the translation has lines for "row count" etc that Avid29 added, which are not yet on the main repo, Some strings are only on Avid29 repo at the moment. So I need to wait until this pull request is accepted, or if Avid29 wants to add the translation to his own repo, it is fine too.

dremin · 2024-11-02T22:38:27Z

Flip the FlowDirection (and item order?)

I tested this and don't think it will do what we want, what are you looking to affect with this change?

I haven't tested it yet, but I expect that if the number of items in the NotifyIconsList is not divisible by the number of rows the system clock side will have empty slots were items would be while the expected behavior is that they would fill in from that side. You'd also still expect the system icons (volume, network, and such) to be on the system clock side.

Our behavior seems to match Windows XP already--the empty slots are on the clock side on both.

Avid29 · 2024-11-02T23:06:47Z

Flip the FlowDirection (and item order?)

I tested this and don't think it will do what we want, what are you looking to affect with this change?

I haven't tested it yet, but I expect that if the number of items in the NotifyIconsList is not divisible by the number of rows the system clock side will have empty slots were items would be while the expected behavior is that they would fill in from that side. You'd also still expect the system icons (volume, network, and such) to be on the system clock side.

Our behavior seems to match Windows XP already--the empty slots are on the clock side on both.

Oh, never mind then

ghost · 2024-11-03T03:33:17Z

Flip the FlowDirection (and item order?)

I tested this and don't think it will do what we want, what are you looking to affect with this change?

I haven't tested it yet, but I expect that if the number of items in the NotifyIconsList is not divisible by the number of rows the system clock side will have empty slots were items would be while the expected behavior is that they would fill in from that side. You'd also still expect the system icons (volume, network, and such) to be on the system clock side.

Our behavior seems to match Windows XP already--the empty slots are on the clock side on both.

"...You'd also still expect the system icons (volume, network, and such) to be on the system clock side..."

empty blocks, volume and network are on the clock side, but "removable devices" is not on clock side on retrobar. I dont know how the "removable devices" is on win xp.

dremin · 2024-11-03T04:16:23Z

Once the requested changes are made, I have a follow up patch to enable drag resizing:

Screen.Recording.2024-11-02.at.11.14.48.PM.mov

ghost · 2024-11-04T06:12:57Z

Once the requested changes are made,

so the remaining changes are: vertical_alignment, rowcount_text, and label target of combo_box?

btw, I noticed that the volume icon is not changing from muted to not-muted icon when clicked, I am not sure if it is retrobar bug or if it is happening only on the multirow version (running on windows 11).

- Added drag resize - Added separate row size setting for themes - Fixes to theme tray metrics with multiple rows - Fixes to theme clock layout with multiple rows - Fixed Vista language bar alignment with multiple rows - Improved Vista and Royale-based theme backgrounds with multiple rows - Improved classic task/toolbar spacing with multiple rows - Addressed review comments

dremin · 2024-11-05T05:51:13Z

I pushed a slew of changes to this branch which adds the drag resize, as well as a bunch of minor theme improvements for multi-row. I believe this is at a point it can be merged, but would appreciate others testing :)

ghost · 2024-11-05T06:30:35Z

I pushed a slew of changes to this branch which adds the drag resize, as well as a bunch of minor theme improvements for multi-row. I believe this is at a point it can be merged, but would appreciate others testing :)

Very nice.

I made a PR for the Finnish translation if you want to add it:
Avid29#1

Resizable taskbar Finnish (Suomi) translation

Avid29 · 2024-11-06T20:37:35Z

@dremin Alright, I believe this should be ready!

dremin

Thanks for working on this, I appreciate it!

RetroBar/Languages/English.xaml

Avid29 added 2 commits October 17, 2024 00:20

WIP Multi-row taskbars

c258280

Exposed desired row height to TaskList and fixed faulty row calculations

0cb3610

Avid29 marked this pull request as draft October 17, 2024 04:33

Avid29 added 4 commits October 17, 2024 01:27

Added RowCount to settings

5fbb4e1

Prevented resizing feedback loop

a010451

Replaced drag resizing with settings options

c544b66

Added Rows being 1 as a condition for top and bottom vista start images

9121e33

Avid29 marked this pull request as ready for review October 17, 2024 07:02

Avid29 changed the title ~~Resizable taskbar~~ Multi-row functionality Oct 17, 2024

Vertically centered toolbar

1480f69

dremin requested changes Oct 18, 2024

View reviewed changes

Avid29 force-pushed the resizable_taskbar branch from 9ffa015 to 8b30505 Compare October 18, 2024 14:14

Avid29 added 2 commits October 18, 2024 10:16

Disabled Row Count Setting when Location is Right or Left

cfc0236

Removed unused drag resizing code

35844b7

Avid29 force-pushed the resizable_taskbar branch from 8b30505 to 35844b7 Compare October 18, 2024 14:16

Avid29 added 2 commits October 18, 2024 10:23

Changed toolbar and XP/System start buttons to top align

ad8a1e0

Display expanded clock for multi-row taskbars

90c76fd

Added conditonal orientation adjustment for NotifyIconList

503d78d

Fixed NotifyIconList orientation update conditions

dfc0413

Changed toolbar icons to also adjust WrapPanel orientation

f9267c8

Avid29 added 2 commits October 29, 2024 01:13

Removed commented code for drag resizing

2dc5583

Added Rows property to PropertiesWindow for preview

d4bdf1e

dremin reviewed Oct 29, 2024

View reviewed changes

MKKNinetyTwo added 2 commits November 5, 2024 08:23

Add Finnish (Suomi) translation.

7a1926b

Add Finnish (Suomi) translation to README.md.

0b29866

Avid29 added 3 commits November 6, 2024 15:34

Merge pull request #1 from MKKNinetyTwo/resizable_taskbar

97c5d17

Resizable taskbar Finnish (Suomi) translation

Changed number of rows text and label binding in properties window

0d3afd7

Merge

8c0d64e

dremin added 2 commits November 7, 2024 23:00

Fix theme regression, fix drag resize on slow systems

d4fa59f

Fix drag resize with high DPI

0017ed2

dremin approved these changes Nov 8, 2024

View reviewed changes

dremin merged commit 924fcef into dremin:master Nov 8, 2024
3 checks passed

xoascf reviewed Nov 8, 2024

View reviewed changes

RetroBar/Languages/English.xaml Show resolved Hide resolved

Avid29 deleted the resizable_taskbar branch November 8, 2024 14:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi-row functionality #928

Multi-row functionality #928

Avid29 commented Oct 17, 2024

Avid29 commented Oct 17, 2024 •

edited

Loading

Avid29 commented Oct 17, 2024

Avid29 commented Oct 17, 2024

dremin commented Oct 17, 2024

dremin left a comment •

edited

Loading

dremin Oct 18, 2024

1280px Oct 18, 2024

dremin Oct 29, 2024

Avid29 commented Oct 18, 2024

Avid29 commented Oct 18, 2024

Avid29 commented Oct 18, 2024

ghost commented Oct 28, 2024 •

edited by ghost

Loading

Avid29 commented Oct 29, 2024

ghost commented Oct 29, 2024

dremin Oct 29, 2024

dremin Oct 29, 2024

dremin Oct 29, 2024

dremin commented Oct 29, 2024

Avid29 commented Oct 30, 2024

ghost commented Nov 2, 2024 •

edited by ghost

Loading

1280px commented Nov 2, 2024

ghost commented Nov 2, 2024 •

edited by ghost

Loading

dremin commented Nov 2, 2024

Avid29 commented Nov 2, 2024

ghost commented Nov 3, 2024 •

edited by ghost

Loading

dremin commented Nov 3, 2024

ghost commented Nov 4, 2024

dremin commented Nov 5, 2024

ghost commented Nov 5, 2024

Avid29 commented Nov 6, 2024

dremin left a comment

Multi-row functionality #928

Multi-row functionality #928

Conversation

Avid29 commented Oct 17, 2024

Avid29 commented Oct 17, 2024 • edited Loading

Avid29 commented Oct 17, 2024

Avid29 commented Oct 17, 2024

dremin commented Oct 17, 2024

dremin left a comment • edited Loading

Choose a reason for hiding this comment

dremin Oct 18, 2024

Choose a reason for hiding this comment

1280px Oct 18, 2024

Choose a reason for hiding this comment

dremin Oct 29, 2024

Choose a reason for hiding this comment

Avid29 commented Oct 18, 2024

Avid29 commented Oct 18, 2024

Avid29 commented Oct 18, 2024

ghost commented Oct 28, 2024 • edited by ghost Loading

Avid29 commented Oct 29, 2024

ghost commented Oct 29, 2024

dremin Oct 29, 2024

Choose a reason for hiding this comment

dremin Oct 29, 2024

Choose a reason for hiding this comment

dremin Oct 29, 2024

Choose a reason for hiding this comment

dremin commented Oct 29, 2024

Avid29 commented Oct 30, 2024

ghost commented Nov 2, 2024 • edited by ghost Loading

1280px commented Nov 2, 2024

ghost commented Nov 2, 2024 • edited by ghost Loading

dremin commented Nov 2, 2024

Avid29 commented Nov 2, 2024

ghost commented Nov 3, 2024 • edited by ghost Loading

dremin commented Nov 3, 2024

ghost commented Nov 4, 2024

dremin commented Nov 5, 2024

ghost commented Nov 5, 2024

Avid29 commented Nov 6, 2024

dremin left a comment

Choose a reason for hiding this comment

Avid29 commented Oct 17, 2024 •

edited

Loading

dremin left a comment •

edited

Loading

ghost commented Oct 28, 2024 •

edited by ghost

Loading

ghost commented Nov 2, 2024 •

edited by ghost

Loading

ghost commented Nov 2, 2024 •

edited by ghost

Loading

ghost commented Nov 3, 2024 •

edited by ghost

Loading